Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Try out further icons optimization (ignore) #44025

Closed
wants to merge 9 commits into from
Closed

[docs] Try out further icons optimization (ignore) #44025

wants to merge 9 commits into from

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Oct 6, 2024 •
edited by oliviertassinari
Loading

@mui-bot
Copy link

mui-bot commented Oct 6, 2024 •
edited
Loading

Netlify deploy preview

https://deploy-preview-44025--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against c53111b

@Janpot Janpot closed this Oct 6, 2024
@Janpot Janpot reopened this Oct 6, 2024
@Janpot Janpot mentioned this pull request Oct 6, 2024
Merged
@Janpot Janpot added the proof of concept Studying and/or experimenting with a to be validated approach label Oct 6, 2024
@oliviertassinari
Copy link
Member

oliviertassinari commented Oct 6, 2024 •
edited
Loading

Observations:

  • https://deploy-preview-44025--material-ui.netlify.app/material-ui/material-icons/?query=a returns inconsistent results, the count changes between each load.
  • The page TTI seems to be around 1.2s instead of 1.9s. It seems we spend 80ms instead or 800ms initially on the search index to hydrate the page. It's a win if the person wants to click on an icon to expend it, but it seems equivalent if the first action the person does is a search. I would expect a search the most common action, so I'm not usure this makes a difference in the UX.

@Janpot
Copy link
Member Author

Janpot commented Oct 6, 2024

returns inconsistent results, the count changes between each load.

Yes, this should lazy initialize instead.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Oct 6, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Oct 6, 2024
@Janpot Janpot closed this Oct 7, 2024
@oliviertassinari oliviertassinari mentioned this pull request Nov 18, 2024
Open
@oliviertassinari
Copy link
Member

Work on this resumed at #44450. It seems that we need it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
package: icons Specific to @mui/icons performance proof of concept Studying and/or experimenting with a to be validated approach
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Janpot @mui-bot @oliviertassinari