[core] Fix CI on v5.x branch #44487
[core] Fix CI on v5.x branch #44487
Conversation
DiegoAndai
force-pushed
the
update-v5.x-core
branch
from
098936b to
2b564b0
Compare
Netlify deploy previewhttps://deploy-preview-44487--material-ui.netlify.app/ @material-ui/core: parsed: +Infinity% , gzip: +Infinity% Bundle size reportDetails of bundle changes (Toolpad) |
DiegoAndai
changed the title
DiegoAndai
force-pushed
the
update-v5.x-core
branch
from
64e35d7 to
cfb1618
Compare
DiegoAndai
changed the title
| @@ -1254,7 +1254,6 @@ describe('<Select />', () => { | |||
| const selectButton = getByTestId('select'); | |||
|
|
|||
| act(() => updateButton.click()); | |||
| act(() => selectButton.click()); | |||
There was a problem hiding this comment.
This was throwing a "not wrapped in act(...)" warning. Not sure why. This click is not necessary for the test. As this is from the stalled base package, and it won't be published from this branch, I don't think it's worth digging deeper into why this was here and/or started throwing.
| @@ -4,7 +4,6 @@ import Box from '@mui/material/Box'; | |||
| import Typography from '@mui/material/Typography'; | |||
| import Paper from '@mui/material/Paper'; | |||
| import LaunchRounded from '@mui/icons-material/LaunchRounded'; | |||
| import { Link } from '@mui/docs/Link'; | |||
There was a problem hiding this comment.
Link is not used in this file, this made eslint fail.
| @@ -74,7 +74,7 @@ | |||
| "test:regressions:run": "mocha --config test/regressions/.mocharc.js --delay 'test/regressions/**/*.test.js'", | |||
| "test:regressions:server": "serve test/regressions -p 5001", | |||
| "test:umd": "node packages/mui-material/test/umd/run.js", | |||
| "test:unit": "cross-env NODE_ENV=test mocha 'packages/**/*.test.{js,ts,tsx}' 'docs/**/*.test.{js,ts,tsx}'", | |||
| "test:unit": "cross-env NODE_ENV=test BROWSERSLIST_IGNORE_OLD_DATA=true mocha 'packages/**/*.test.{js,ts,tsx}' 'docs/**/*.test.{js,ts,tsx}'", | |||
There was a problem hiding this comment.
We're ok with browserslist being outdated in this branch, this flag is already in use for the builds:
Line 10 in f6181da
| @@ -54,10 +54,6 @@ function createDOM() { | |||
| } | |||
| global.window.Touch = Touch; | |||
|
|
|||
| global.navigator = { | |||
There was a problem hiding this comment.
Cherry picked from #42344
| @@ -6,7 +6,7 @@ describe('animate', () => { | |||
|
|
|||
| before(function beforeHook() { | |||
| const isSafari = /^((?!chrome|android).)*safari/i.test(navigator.userAgent); | |||
| const isJSDOM = navigator.userAgent === 'node.js'; | |||
There was a problem hiding this comment.
Cherry picked from #42344
| @@ -46,7 +46,7 @@ function hasRightScrollButton(container) { | |||
|
|
|||
| describe('<Tabs />', () => { | |||
| // tests mocking getBoundingClientRect prevent mocha to exit | |||
| const isJSDOM = navigator.userAgent === 'node.js'; | |||
There was a problem hiding this comment.
Cherry picked from #42344
A new attempt at #43564, same motivation.
Update v5.x to the same pnpm version as master (so it's easier to switch between both), as well as run
pnpm dedupeso the CI is green again.This is to prepare for #44413.