Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Material UI] Update overridesResolver return from object to array of styles #44752

Merged
merged 4 commits into from
Dec 13, 2024
Merged

[Material UI] Update overridesResolver return from object to array of styles #44752

merged 4 commits into from
Dec 13, 2024

Conversation

siddhantantil39
Copy link
Contributor

@siddhantantil39 siddhantantil39 commented Dec 12, 2024 •
edited
Loading

works to fix: #44699

@mui-bot
Copy link

mui-bot commented Dec 12, 2024 •
edited
Loading

Netlify deploy preview

https://deploy-preview-44752--material-ui.netlify.app/

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against 512fad4

@siddhantantil39 siddhantantil39 marked this pull request as draft December 13, 2024 07:10
@siddhantantil39 siddhantantil39 marked this pull request as ready for review December 13, 2024 07:36
siriwatknp
siriwatknp approved these changes Dec 13, 2024
View reviewed changes
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good, Thanks a lot!

@siriwatknp siriwatknp added component: autocomplete This is the name of the generic UI component, not the React module! component: avatar This is the name of the generic UI component, not the React module! component: card This is the name of the generic UI component, not the React module! component: FormControl The React component labels Dec 13, 2024
@siriwatknp siriwatknp changed the title issue-44699: changed overridesResolver return from object based to array based styles [Material UI] Update overridesResolver return from object based to array based styles Dec 13, 2024
@siriwatknp siriwatknp changed the title [Material UI] Update overridesResolver return from object based to array based styles [Material UI] Update overridesResolver return from object to array of styles Dec 13, 2024
@siriwatknp siriwatknp merged commit 68e3b40 into mui:master Dec 13, 2024
23 checks passed
@brentertz brentertz mentioned this pull request Dec 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriwatknp siriwatknp siriwatknp approved these changes

Assignees
No one assigned
Labels
component: autocomplete This is the name of the generic UI component, not the React module! component: avatar This is the name of the generic UI component, not the React module! component: card This is the name of the generic UI component, not the React module! component: FormControl The React component
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FormLabel] Style overrides with variants do not work
3 participants
@siddhantantil39 @mui-bot @siriwatknp