-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Add overriding-component-structure
doc to Material UI
#45186
base: master
Are you sure you want to change the base?
Conversation
Netlify deploy previewBundle size report |
…aterial-ui into docs/mui-override-component
...data/material/customization/overriding-component-structure/overriding-component-structure.md
Outdated
Show resolved
Hide resolved
…e/overriding-component-structure.md Signed-off-by: Siriwat K <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add a section explaining why slots
and slotProps
are better than the deprecated *Component
and *Props
props? The advantage isn’t clear to me atleast beyond reducing multiple *Component
and *Props
props to just two (slots
and slotProps
).
options={[ | ||
{ label: '🆘 Need help' }, | ||
{ label: '✨ Improvement' }, | ||
{ label: '🚀 New feature' }, | ||
{ label: '🐛 Bug fix' }, | ||
]} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can pass options without label
property:
options={[ | |
{ label: '🆘 Need help' }, | |
{ label: '✨ Improvement' }, | |
{ label: '🚀 New feature' }, | |
{ label: '🐛 Bug fix' }, | |
]} | |
options={['🆘 Need help', '✨ Improvement', '🚀 New feature', '🐛 Bug fix']} |
closes #41281
This PR will be merged once the rest of the tasks in #41281 are done. Open this early to give @mapache-salvaje time to review.