Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add overriding-component-structure doc to Material UI #45186

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

siriwatknp
Copy link
Member

@siriwatknp siriwatknp commented Feb 3, 2025

closes #41281

This PR will be merged once the rest of the tasks in #41281 are done. Open this early to give @mapache-salvaje time to review.


@siriwatknp siriwatknp added docs Improvements or additions to the documentation package: material-ui Specific to @mui/material labels Feb 3, 2025
@mui-bot
Copy link

mui-bot commented Feb 3, 2025

…e/overriding-component-structure.md

Signed-off-by: Siriwat K <[email protected]>
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a section explaining why slots and slotProps are better than the deprecated *Component and *Props props? The advantage isn’t clear to me atleast beyond reducing multiple *Component and *Props props to just two (slots and slotProps).

Comment on lines +24 to +29
options={[
{ label: '🆘 Need help' },
{ label: '✨ Improvement' },
{ label: '🚀 New feature' },
{ label: '🐛 Bug fix' },
]}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can pass options without label property:

Suggested change
options={[
{ label: '🆘 Need help' },
{ label: '✨ Improvement' },
{ label: '🚀 New feature' },
{ label: '🐛 Bug fix' },
]}
options={['🆘 Need help', '✨ Improvement', '🚀 New feature', '🐛 Bug fix']}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation package: material-ui Specific to @mui/material
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[material-ui] Deprecate *Component and *Props props
4 participants