-
-
Notifications
You must be signed in to change notification settings - Fork 32.6k
[core] refactor: remove manual displayName #46147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Netlify deploy previewhttps://deploy-preview-46147--material-ui.netlify.app/ @mui/material: parsed: +0.12% , gzip: +0.10% Bundle size reportDetails of bundle changes (Toolpad) |
🤔 Where does the bundle size increase come from? Shouldn't these be wrapped in a |
It's all wrapped, here is the output of |
The current implementation runs webpack with minifier on a virtual module that imports the package and compares the result with merge base. Interestingly it seems to minify differently. Looks like in the baseline it omits variable declaration in the function body to create a global var, and in this PR it explicitly creates those const in global scope. Quite odd, maybe whitespace related in terser. https://gist.github.com/Janpot/2d3156e4ee4302687e29ae848f230c06 For now it probably makes most sense to not run this plugin on the tests. |
I've disabled the plugin in test. This is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We started publishing from mui-public in the meantime. So the workspace dependency can be removed.
https://www.npmjs.com/package/@mui/internal-babel-plugin-display-name
Follow-up of mui/base-ui#1920
Depends on mui/mui-public#329
closes #44067