Skip to content

[code-infra] Fix test_types_next job #46182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 9 additions & 22 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -273,35 +273,15 @@ jobs:
- run:
name: Tests TypeScript definitions
command: |
# ignore build failures
# it's expected that typescript@next fails since the lines of the errors
# change frequently. This build is monitored regardless of its status
set +e
pnpm typescript:ci
exit 0
- restore_cache:
name: Restore generated declaration files
keys:
# We assume that the target branch is `next` and that declaration files are persisted in commit order.
# "If there are multiple matches, the most recently generated cache will be used."
- typescript-declaration-files-next
- run:
name: Diff declaration files
name: Build declaration files
command: |
git add -f packages/mui-material/build || echo '/core declarations do not exist'
git add -f packages/mui-lab/build || echo '/lab declarations do not exist'
git add -f packages/mui-utils/build || echo '/utils declarations do not exist'
pnpm -r build:types
git --no-pager diff
pnpm -r build:stable && pnpm -r build:types
- run:
name: Log defect declaration files
command: |
# ignore build failures
# Fixing these takes some effort that isn't viable to merge in a single PR.
# We'll simply monitor them for now.
set +e
node scripts/testBuiltTypes.mjs
exit 0
test_browser:
<<: *default-job
resource_class: 'medium+'
Expand Down Expand Up @@ -893,6 +873,13 @@ workflows:
name: test_e2e-react@next

typescript-next:
when:
equal: [typescript-next, << pipeline.parameters.workflow >>]
jobs:
- test_types_next:
<<: *default-context

typescript-next-cron:
triggers:
- schedule:
cron: '0 0 * * *'
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@
"test:unit": "nx run nx_test_unit",
"test:argos": "node ./scripts/pushArgos.mjs test/regressions/screenshots/chrome",
"typescript": "lerna run --no-bail typescript",
"typescript:ci": "lerna run --concurrency 3 --no-bail typescript",
"typescript:ci": "lerna run --concurrency 2 --no-bail typescript",
"use-react-version": "node ./scripts/useReactVersion.mjs",
"validate-declarations": "tsx scripts/validateTypescriptDeclarations.mts",
"generate-codeowners": "node scripts/generateCodeowners.mjs",
Expand Down
Loading