[SnackbarContent] Fix error when theme value is CSS variable #46198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZeeshanTamboli
added
bug 🐛
ZeeshanTamboli
changed the title
Netlify deploy previewhttps://deploy-preview-46198--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
ZeeshanTamboli
approved these changes
May 24, 2025
There was a problem hiding this comment.
@0210shivam Thanks for the pull request. Looks good. Just changed from using extendTheme to createTheme with cssVariables option in test.
Thanks for merging and for the update! Appreciate it. 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes #46192 by the SnackbarContentRoot from applying the emphasize color function to
theme.palette.background.default, ensuring correct theming behavior when using background defaults. Also added a test case to verify correct application of the CSS variable