Skip to content

[material-nextjs][system] Backport CSS layers to v6 #46283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: v6.x
Choose a base branch
from

Conversation

- Add enableCssLayer option to createEmotionCache for pages router
- Export createEmotionCache from v13-pagesRouter module
- Update SSR emotion styles to handle CSS layer order rules properly
- Prevent CSS layer order flickering during hydration

Backport of mui#45596 to v6.x branch
- Document how to enable CSS layers with createEmotionCache
- Update CSS theme variables heading level to h3
- Add examples for both _document.tsx and _app.tsx setup

Part of backport of mui#45596 to v6.x branch
@mui-bot
Copy link

mui-bot commented Jun 6, 2025

Netlify deploy preview

@mui/joy/GlobalStyles: parsed: +14.94% , gzip: +20.34%
@mui/joy/CssBaseline: parsed: +14.70% , gzip: +19.96%
GlobalStyles: parsed: +13.08% , gzip: +17.27%
CssBaseline: parsed: +12.53% , gzip: +16.53%
@material-ui/core: parsed: +0.33% , gzip: +0.35%
@material-ui/system: parsed: +2.11% , gzip: +1.77%
@mui/joy: parsed: +0.33% , gzip: +0.21%
TextField: parsed: +0.61% , gzip: +0.64%
OutlinedInput: parsed: +0.99% , gzip: +0.97%
NativeSelect: parsed: +0.98% , gzip: +0.94%
FilledInput: parsed: +0.95% , gzip: +0.99%
InputBase: parsed: +1.01% , gzip: +0.99%
ScopedCssBaseline: parsed: +1.11% , gzip: +1.08%
Radio: parsed: +0.77% , gzip: +0.62%
Breadcrumbs: parsed: +0.67% , gzip: +0.66%
Checkbox: parsed: +0.68% , gzip: +0.59%
SwipeableDrawer: parsed: +0.59% , gzip: +0.57%
CardHeader: parsed: +0.79% , gzip: +0.85%
ListItemText: parsed: +0.79% , gzip: +0.85%
Grid2: parsed: +0.81% , gzip: +0.83%
and 181 more changes

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against f9c0b65

…ple CSS layers (mui#46001)

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
@siriwatknp siriwatknp changed the title [material-nextjs] Back port CSS layers for pages router [material-nextjs][system] Back port CSS layers to v6 Jun 12, 2025
@siriwatknp siriwatknp added package: system Specific to @mui/system nextjs cherry-pick The PR was cherry-picked from the newer alpha/beta/stable branch labels Jun 12, 2025
@siriwatknp siriwatknp changed the title [material-nextjs][system] Back port CSS layers to v6 [material-nextjs][system] Backport CSS layers to v6 Jun 12, 2025
@siriwatknp siriwatknp marked this pull request as ready for review June 12, 2025 09:48
@siriwatknp siriwatknp added v6.x new feature New feature or request labels Jun 12, 2025
@zannager zannager requested a review from mnajdova June 13, 2025 03:17
@siriwatknp siriwatknp requested review from DiegoAndai and sai6855 June 16, 2025 08:52
@siriwatknp
Copy link
Member Author

Added @sai6855 as a reviewer, in case you see anything missing/wrong.

Copy link
Member

@DiegoAndai DiegoAndai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good @siriwatknp!

May I ask you to point me to what's different between this implementation and v7's?


head.prepend(styleElement);
} else {
head.querySelector(`style[data-mui-layer-order="${id}"]`)?.remove();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we remove this?

Comment on lines +200 to +204
if (!serialized.variants) {
return props.theme.modularCssLayers
? shallowLayer(serialized.style, layerName)
: serialized.style;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reason to move this inside the styleObjectProcessor function?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick The PR was cherry-picked from the newer alpha/beta/stable branch new feature New feature or request nextjs package: system Specific to @mui/system v6.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants