-
-
Notifications
You must be signed in to change notification settings - Fork 32.7k
[useScrollTrigger] refactor: improve scroll event handling with requestAnimationFrame throttling #46968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
wo-o29
wants to merge
11
commits into
mui:master
Choose a base branch
from
wo-o29:refactor/useScrollTrigger-add-raf
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+30
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-46968--material-ui.netlify.app/ Bundle size report
|
…roll event simulation
…or better scroll event handling
… for improved performance
…lAnimationFrame in tests
I also fixed that part because pnpm-lock.yaml was out of date and the ci test was failing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the
useScrollTrigger
hook by introducingrequestAnimationFrame
throttling to the scroll event listener.Improvements and Benefits:
ticking
flag combined withrequestAnimationFrame
to throttle scroll event handling, reducing the number of state updates and re-renders on rapid scroll events.These changes help optimize performance without changing the hook’s external behavior or API.