Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Prevent e.g. typo #10193

Merged
merged 1 commit into from
Sep 1, 2023
Merged

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Aug 31, 2023

I'm not sure it's helpful, but why not mui/material-ui#38748

Screenshot 2023-08-31 at 23 44 30

@oliviertassinari oliviertassinari added the core Infrastructure work going on behind the scenes label Aug 31, 2023
@mui-bot
Copy link

mui-bot commented Aug 31, 2023

Netlify deploy preview

Netlify deploy preview: https://deploy-preview-10193--material-ui-x.netlify.app/

Updated pages

No updates.

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms -198.9 67.7 -198.9 -47.2 88.882
Sort 100k rows ms 691 1,604 1,440.6 1,290.68 312.985
Select 100k rows ms 700.5 871.6 796.6 784.28 56.124
Deselect 100k rows ms 141.8 198.7 150.1 163.06 22.268

Generated by 🚫 dangerJS against 672a0fa

@oliviertassinari oliviertassinari merged commit 0dd2b92 into mui:master Sep 1, 2023
4 of 5 checks passed
@oliviertassinari oliviertassinari deleted the vale-eg-typo branch September 1, 2023 09:19
@samuelsycamore
Copy link
Contributor

Even better would be a rule to disallow Latinisms like "e.g." "i.e." "etc." and such entirely. I thought this was already a rule in the Style Guide, but I'm not seeing it now. These shorthand phrases are often misused (for example, "i.e." when you really mean "e.g." or vice versa) and not always understood by non-native English speakers.

@oliviertassinari
Copy link
Member Author

oliviertassinari commented Sep 2, 2023

@samuelsycamore Oh, interesting. I fixed the same issues in the core with mui/material-ui#38748. We use these a lot 🙃.


I have created mui/mui-public#226 as it seems it would be great to have Vale in Core.

oliviertassinari added a commit to mui/material-ui that referenced this pull request Sep 2, 2023
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Sep 8, 2023
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Sep 8, 2023
xcode-it pushed a commit to xcode-it/material-ui that referenced this pull request Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants