Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[charts] Update package.json for vendor package #14465

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

alexfauquette
Copy link
Member

@mui-bot
Copy link

mui-bot commented Sep 3, 2024

Deploy preview: https://deploy-preview-14465--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 1b1157c

@alexfauquette alexfauquette added the component: charts This is the name of the generic UI component, not the React module! label Sep 3, 2024
Copy link

codspeed-hq bot commented Sep 3, 2024

CodSpeed Performance Report

Merging #14465 will not alter performance

Comparing alexfauquette:cjs (1b1157c) with master (2cb93f4)

Summary

✅ 3 untouched benchmarks

@alexfauquette alexfauquette merged commit 06527da into mui:master Sep 3, 2024
20 of 21 checks passed
@alexfauquette alexfauquette deleted the cjs branch September 3, 2024 13:16
@oliviertassinari oliviertassinari added the core Infrastructure work going on behind the scenes label Sep 13, 2024
@@ -12,7 +11,8 @@
],
"repository": {
"type": "git",
"url": "https://github.com/mui/mui-x"
"url": "https://github.com/mui/mui-x.git",
Copy link
Member

@oliviertassinari oliviertassinari Sep 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that it should be:

Suggested change
"url": "https://github.com/mui/mui-x.git",
"url": "git+https://github.com/mui/mui-x.git",

per https://docs.npmjs.com/cli/v10/configuring-npm/package-json#repository.

I have updated all the codebase (Base UI, Material UI, Pigment CSS, Toolpad, MUI X).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: charts This is the name of the generic UI component, not the React module! core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants