-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[charts-pro] Fix CSP error on print export #20053
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
bernardobelchior
wants to merge
17
commits into
mui:master
Choose a base branch
from
bernardobelchior:fix-export-csp-issue
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[charts-pro] Fix CSP error on print export #20053
bernardobelchior
wants to merge
17
commits into
mui:master
from
bernardobelchior:fix-export-csp-issue
+275
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview: https://deploy-preview-20053--material-ui-x.netlify.app/ Updated pages:
Bundle size report
|
CodSpeed Performance ReportMerging #20053 will not alter performanceComparing Summary
Footnotes |
3418200 to
cd61395
Compare
e6c9847 to
cd61395
Compare
a014b37 to
4580ffe
Compare
4580ffe to
7c7d108
Compare
This reverts commit 4bafab1.
4f0cad2 to
8818b35
Compare
This reverts commit 7c7d108.
268300f to
2b8c1d7
Compare
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
PR: out-of-date
The pull request has merge conflicts and can't be merged.
scope: charts
Changes related to the charts.
type: bug
It doesn't behave as expected.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #20037.
Allows a user to provide a
nonceto fix the CSP error on print export whenstyle-src-elem 'nonce-r4nd0m'is specified in theContent-Security-Policyheader.The image export fix will take longer as we'll likely need to upstream changes to
rasterizehtmland/orinlineresources(or patch them), so I'm creating this PR first and will handle the image export later.inlineresourcesPR