Skip to content

Conversation

@bernardobelchior
Copy link
Member

@bernardobelchior bernardobelchior commented Oct 22, 2025

Part of #20037.

Allows a user to provide a nonce to fix the CSP error on print export when style-src-elem 'nonce-r4nd0m' is specified in the Content-Security-Policy header.

The image export fix will take longer as we'll likely need to upstream changes to rasterizehtml and/or inlineresources (or patch them), so I'm creating this PR first and will handle the image export later.

inlineresources PR

@bernardobelchior bernardobelchior added type: bug It doesn't behave as expected. scope: charts Changes related to the charts. labels Oct 22, 2025
@mui-bot
Copy link

mui-bot commented Oct 22, 2025

Deploy preview: https://deploy-preview-20053--material-ui-x.netlify.app/

Updated pages:

Bundle size report

Bundle Parsed size Gzip size
@mui/x-data-grid ▼-56B(-0.01%) 🔺+4B(0.00%)
@mui/x-data-grid-pro ▼-56B(-0.01%) 🔺+2B(0.00%)
@mui/x-data-grid-premium ▼-56B(-0.01%) 🔺+3B(0.00%)
@mui/x-charts 0B(0.00%) 0B(0.00%)
@mui/x-charts-pro ▼-13B(0.00%) 🔺+31B(+0.02%)
@mui/x-charts-premium ▼-13B(0.00%) 🔺+25B(+0.02%)
@mui/x-date-pickers 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers-pro 0B(0.00%) 0B(0.00%)
@mui/x-tree-view 0B(0.00%) 0B(0.00%)
@mui/x-tree-view-pro 0B(0.00%) 0B(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against 38e893e

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 22, 2025

CodSpeed Performance Report

Merging #20053 will not alter performance

Comparing bernardobelchior:fix-export-csp-issue (0a757f9) with master (7e3eead)1

Summary

✅ 13 untouched

Footnotes

  1. No successful run was found on master (9771584) during the generation of this report, so 7e3eead was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@bernardobelchior bernardobelchior force-pushed the fix-export-csp-issue branch 3 times, most recently from 3418200 to cd61395 Compare October 22, 2025 11:35
@bernardobelchior bernardobelchior changed the title [charts-pro] Fix CSP error on export [charts-pro] Fix CSP error on print export Oct 23, 2025
@bernardobelchior bernardobelchior force-pushed the fix-export-csp-issue branch 2 times, most recently from a014b37 to 4580ffe Compare October 23, 2025 13:54
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Nov 3, 2025
@github-actions
Copy link

github-actions bot commented Nov 3, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: out-of-date The pull request has merge conflicts and can't be merged. scope: charts Changes related to the charts. type: bug It doesn't behave as expected.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants