Skip to content

Conversation

@prakhargupta1
Copy link
Member

@prakhargupta1 prakhargupta1 commented Oct 23, 2025

@prakhargupta1 prakhargupta1 added docs Improvements or additions to the documentation. type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. scope: charts Changes related to the charts. labels Oct 23, 2025
@mui-bot
Copy link

mui-bot commented Oct 23, 2025

Deploy preview: https://deploy-preview-20073--material-ui-x.netlify.app/

Updated pages:

Bundle size report

Bundle Parsed size Gzip size
@mui/x-data-grid 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-pro 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-premium 0B(0.00%) 0B(0.00%)
@mui/x-charts 0B(0.00%) 0B(0.00%)
@mui/x-charts-pro 0B(0.00%) 0B(0.00%)
@mui/x-charts-premium 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers-pro 0B(0.00%) 0B(0.00%)
@mui/x-tree-view 0B(0.00%) 0B(0.00%)
@mui/x-tree-view-pro 0B(0.00%) 0B(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against 914029f

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 23, 2025

CodSpeed Performance Report

Merging #20073 will not alter performance

Comparing prakhargupta1:svg-icon (914029f) with master (2423e2f)1

Summary

✅ 13 untouched

Footnotes

  1. No successful run was found on master (fc6ab97) during the generation of this report, so 2423e2f was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@prakhargupta1
Copy link
Member Author

@alexfauquette Do you think this demo is meaningful to be added to the docs? If Yes, is 'Custom components' the right place for it?

@alexfauquette
Copy link
Member

Maybe axis customization would be better 🤔
https://mui.com/x/react-charts/axis/#axis-customization

@prakhargupta1 prakhargupta1 marked this pull request as ready for review November 5, 2025 06:23

return (
<g transform={`translate(${x},${y})`}>
<foreignObject x={-20} y={0} width={60} height={50}>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit weird that we're using a foreignObject to render an SVG icon, but I guess it's valid.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it feels a bit useless. You could probably achieve this more efficiently with just the svg.

Maybe we could use the logo images here instead? 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, I'll try that.

Co-authored-by: Bernardo Belchior <[email protected]>
Signed-off-by: Prakhar Gupta <[email protected]>
@prakhargupta1 prakhargupta1 merged commit 51a6dc5 into mui:master Nov 6, 2025
22 checks passed
@prakhargupta1 prakhargupta1 deleted the svg-icon branch November 6, 2025 04:56
@bernardobelchior
Copy link
Member

The images are not centered on mobile.

image

To properly fix this, I think we need to access the xScale and obtain the bar's width so that we can properly center the images within the bar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Improvements or additions to the documentation. scope: charts Changes related to the charts. type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants