-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[scheduler] Testing - event builders for reducing test boilerplate #20081
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rita-codes
merged 24 commits into
mui:master
from
rita-codes:poc-event-builders-for-testing
Nov 3, 2025
Merged
[scheduler] Testing - event builders for reducing test boilerplate #20081
rita-codes
merged 24 commits into
mui:master
from
rita-codes:poc-event-builders-for-testing
Nov 3, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview: https://deploy-preview-20081--material-ui-x.netlify.app/ Bundle size report
|
flaviendelangle
approved these changes
Nov 3, 2025
Member
flaviendelangle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One final comment and we are good to go.
Thanks for doing it!
It will make the tests a lot more robust and easy to manipulate!
bernardobelchior
pushed a commit
to bernardobelchior/mui-x
that referenced
this pull request
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
scope: scheduler
Changes related to the scheduler.
test
type: enhancement
It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A tiny, type-safe Event Builder for tests with a simple API for complex things like recurrence
Why this helps
Tests no longer need to manually create full CalendarEvent objects with adapter.date(...) everywhere.
Common patterns like "single-day timed event", "all-day span", or "weekly recurrence" become one-liners, which keeps tests readable and focused on behavior instead of setup.
The builder relies on the adapter so it automatically respects locale, time zones, and weekday mapping, no more mismatches caused by hardcoded weekday codes or date math.
Use examples
Full default event:
Produces a valid CalendarEventOccurrence with: Randomized id, auto title and description, starts at
DEFAULT_TESTING_VISIBLE_DATE, duration 60 min and realistic key.Weekly recurring event with startAt
All day spaning multiple days with title