Skip to content

[scheduler] Improve the drag and drop utils to support resource change #20088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Nov 3, 2025
Merged

[scheduler] Improve the drag and drop utils to support resource change #20088

merged 15 commits into from
Nov 3, 2025

Conversation

@flaviendelangle
Copy link
Member

@flaviendelangle flaviendelangle commented Oct 24, 2025 •
edited
Loading

Extracted from #19966

The placeholder now contain the resource to drop the event into.

@flaviendelangle flaviendelangle self-assigned this Oct 24, 2025
@flaviendelangle flaviendelangle added type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. scope: scheduler Changes related to the scheduler. labels Oct 24, 2025
@mui-bot
Copy link

mui-bot commented Oct 24, 2025 •
edited
Loading

Deploy preview: https://deploy-preview-20088--material-ui-x.netlify.app/

Updated pages:

Bundle size report

Bundle Parsed size Gzip size
@mui/x-data-grid 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-pro 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-premium 0B(0.00%) 0B(0.00%)
@mui/x-charts 0B(0.00%) 0B(0.00%)
@mui/x-charts-pro 0B(0.00%) 0B(0.00%)
@mui/x-charts-premium 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers-pro 0B(0.00%) 0B(0.00%)
@mui/x-tree-view 0B(0.00%) 0B(0.00%)
@mui/x-tree-view-pro 0B(0.00%) 0B(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against ff3a3f5

flaviendelangle
flaviendelangle commented Oct 24, 2025
View reviewed changes
...s/src/calendar-grid/time-event-placeholder/CalendarGridTimeEventPlaceholderDataAttributes.ts
@@ -0,0 +1,10 @@
export enum CalendarGridTimeEventPlaceholderDataAttributes {
Copy link
Member Author

@flaviendelangle flaviendelangle Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot this file in #19989

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Oct 24, 2025
@github-actions
Copy link

github-actions bot commented Oct 24, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Oct 27, 2025
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Oct 29, 2025
@github-actions
Copy link

github-actions bot commented Oct 29, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Oct 29, 2025
@flaviendelangle flaviendelangle marked this pull request as ready for review October 29, 2025 12:58
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Oct 30, 2025
@github-actions
Copy link

github-actions bot commented Oct 30, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Oct 31, 2025
@flaviendelangle flaviendelangle mentioned this pull request Oct 31, 2025
Open
rita-codes
rita-codes reviewed Nov 3, 2025
View reviewed changes
rita-codes
rita-codes approved these changes Nov 3, 2025
View reviewed changes
Copy link
Member

@rita-codes rita-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of comments, other than that LGTM! :shipit:

@flaviendelangle flaviendelangle merged commit 820ac86 into mui:master Nov 3, 2025
21 checks passed
@flaviendelangle flaviendelangle deleted the resource-dnd branch November 3, 2025 11:44
bernardobelchior pushed a commit to bernardobelchior/mui-x that referenced this pull request Nov 3, 2025
@flaviendelangle @bernardobelchior
[scheduler] Improve the drag and drop utils to support resource change (
309173a 
mui#20088)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rita-codes rita-codes rita-codes approved these changes

@noraleonte noraleonte Awaiting requested review from noraleonte

Assignees

@flaviendelangle flaviendelangle

Labels

scope: scheduler Changes related to the scheduler. type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@flaviendelangle @mui-bot @rita-codes