Skip to content

[code-infra] Add new broken links checker #20120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

[code-infra] Add new broken links checker #20120

wants to merge 14 commits into from
+150 −194

Conversation

@Janpot
Copy link
Member

@Janpot Janpot commented Oct 28, 2025

@Janpot Janpot mentioned this pull request Oct 28, 2025
Merged
3 tasks
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Oct 28, 2025
@github-actions
Copy link

github-actions bot commented Oct 28, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@Janpot Janpot added scope: code-infra Involves the code-infra product (https://www.notion.so/mui-org/5562c14178aa42af97bc1fa5114000cd). type: new feature Expand the scope of the product to solve a new problem. labels Oct 28, 2025
@mui-bot
Copy link

mui-bot commented Oct 28, 2025 •
edited
Loading

Deploy preview: https://deploy-preview-20120--material-ui-x.netlify.app/

Bundle size report

Bundle Parsed size Gzip size
@mui/x-data-grid 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-pro 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-premium 0B(0.00%) 0B(0.00%)
@mui/x-charts 0B(0.00%) 0B(0.00%)
@mui/x-charts-pro 0B(0.00%) 0B(0.00%)
@mui/x-charts-premium 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers-pro 0B(0.00%) 0B(0.00%)
@mui/x-tree-view 0B(0.00%) 0B(0.00%)
@mui/x-tree-view-pro 0B(0.00%) 0B(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against d4a346a

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Oct 28, 2025
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Oct 28, 2025
@github-actions
Copy link

github-actions bot commented Oct 28, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Oct 28, 2025
@Janpot Janpot marked this pull request as ready for review October 29, 2025 18:11
@Janpot Janpot requested a review from a team October 29, 2025 18:11
flaviendelangle
flaviendelangle reviewed Oct 31, 2025
View reviewed changes
eslint.config.mjs
],

// TODO enable:
'react-hooks/refs': 'off',
Copy link
Member

@flaviendelangle flaviendelangle Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add those package per package like we did for the React Compiler ?
Or do you think it's feasible to migrate the whole codebase at once for some of those rules ?

Copy link
Member Author

@Janpot Janpot Oct 31, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should tackle the per package, but we're still figuring out if we should enable react compiler at all. And if we do, perhaps it should only be ab opt-in per component.

For now I just added these to make eslint shut up after a recent update to react-hooks in code-infra

Copy link
Member

@flaviendelangle flaviendelangle Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK make sense 👍
We can do a follow up moving those rules package per package if we think the goal is to enable them.

Even without enabling the compiler itself (I'm clearly not in favor of doing it today 😆 ), some of those rules can be good practices. But it's clearly not the top priority right now.

Copy link
Member Author

@Janpot Janpot Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main problem is that many of the rules are actually quite hard to statically analyze, and the lint plugin is not doing a great job in terms of false positives.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Nov 3, 2025
@github-actions
Copy link

github-actions bot commented Nov 3, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@flaviendelangle flaviendelangle flaviendelangle left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

PR: out-of-date The pull request has merge conflicts and can't be merged. scope: code-infra Involves the code-infra product (https://www.notion.so/mui-org/5562c14178aa42af97bc1fa5114000cd). type: new feature Expand the scope of the product to solve a new problem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Janpot @mui-bot @flaviendelangle