Skip to content

[scheduler] Create a utility hook to format a time with/without ampm #20149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 30, 2025
Merged

[scheduler] Create a utility hook to format a time with/without ampm #20149

merged 2 commits into from
Oct 30, 2025

Conversation

@flaviendelangle
Copy link
Member

@flaviendelangle flaviendelangle commented Oct 30, 2025 •
edited
Loading

Will be useful with #20145
All those ternary were hurting me 😆

I also added a scheduler selector for ampm to be able to retrieve it in code shared by both components.

@flaviendelangle flaviendelangle self-assigned this Oct 30, 2025
@flaviendelangle flaviendelangle added type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. scope: scheduler Changes related to the scheduler. labels Oct 30, 2025
@mui-bot
Copy link

mui-bot commented Oct 30, 2025 •
edited
Loading

Deploy preview: https://deploy-preview-20149--material-ui-x.netlify.app/

Bundle size report

Bundle Parsed size Gzip size
@mui/x-data-grid 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-pro 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-premium 0B(0.00%) 0B(0.00%)
@mui/x-charts 0B(0.00%) 0B(0.00%)
@mui/x-charts-pro 0B(0.00%) 0B(0.00%)
@mui/x-charts-premium 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers-pro 0B(0.00%) 0B(0.00%)
@mui/x-tree-view 0B(0.00%) 0B(0.00%)
@mui/x-tree-view-pro 0B(0.00%) 0B(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against aa1ef84

@flaviendelangle flaviendelangle marked this pull request as ready for review October 30, 2025 13:48
noraleonte
noraleonte approved these changes Oct 30, 2025
View reviewed changes
Copy link
Contributor

@noraleonte noraleonte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this cleanup 🎉 🧹

@flaviendelangle flaviendelangle merged commit 62192df into mui:master Oct 30, 2025
21 checks passed
@flaviendelangle flaviendelangle deleted the format-time branch October 30, 2025 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@noraleonte noraleonte noraleonte approved these changes

@rita-codes rita-codes Awaiting requested review from rita-codes

Assignees

@flaviendelangle flaviendelangle

Labels

scope: scheduler Changes related to the scheduler. type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@flaviendelangle @mui-bot @noraleonte