Skip to content

fix/export print all the rows in v7.x #20157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: v7.x
Choose a base branch
from
+7 −11
Open

fix/export print all the rows in v7.x #20157

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e25c87d
refactor: bump number of rows in ExportDefaultToolbar to 50
m2mathew Oct 30, 2025
dc2b560
fix: disable virtualization in exportDataAsPrint
m2mathew Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/data/data-grid/export/ExportDefaultToolbar.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { DataGrid, GridToolbar } from '@mui/x-data-grid';
export default function ExportDefaultToolbar() {
const { data, loading } = useDemoData({
dataSet: 'Commodity',
rowLength: 4,
rowLength: 50,
maxColumns: 6,
});

Expand Down
2 changes: 1 addition & 1 deletion docs/data/data-grid/export/ExportDefaultToolbar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { DataGrid, GridToolbar } from '@mui/x-data-grid';
export default function ExportDefaultToolbar() {
const { data, loading } = useDemoData({
dataSet: 'Commodity',
rowLength: 4,
rowLength: 50,
maxColumns: 6,
});

Expand Down
14 changes: 5 additions & 9 deletions packages/x-data-grid/src/hooks/features/export/useGridPrintExport.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,15 +279,17 @@ export const useGridPrintExport = (

// Revert grid to previous state
apiRef.current.restoreState(previousGridState.current || {});

if (!previousGridState.current?.columns?.columnVisibilityModel) {
// if the apiRef.current.exportState(); did not exported the column visibility, we update it
// if the apiRef.current.exportState(); did not export the column visibility, we update it
apiRef.current.setColumnVisibilityModel(previousColumnVisibility.current);
}

apiRef.current.setState((state) => ({
...state,
virtualization: previousVirtualizationState.current!,
}));

apiRef.current.setRows(previousRows.current);

// Clear local state
Expand Down Expand Up @@ -333,14 +335,8 @@ export const useGridPrintExport = (
}));
}
previousVirtualizationState.current = apiRef.current.state.virtualization;
apiRef.current.setState((state) => ({
...state,
virtualization: {
...state.virtualization,
enabled: false,
enabledForColumns: false,
},
}));

apiRef.current.unstable_setVirtualization(false);

await updateGridColumnsForPrint(
options?.fields,
Expand Down