[scheduler] Add tests for eventCalendarEventSelectors
#20160
Merged
+238
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaviendelangle
added
test
type: enhancement
flaviendelangle
commented
Oct 31, 2025
| isResizable: createSelector( | ||
| (state: State, eventId: CalendarEventId, surfaceType: EventSurfaceType) => { | ||
| if (schedulerSelectors.isEventReadOnly(state, eventId) || !state.areEventsDraggable) { | ||
| if (schedulerSelectors.isEventReadOnly(state, eventId) || !state.areEventsResizable) { |
|
Deploy preview: https://deploy-preview-20160--material-ui-x.netlify.app/ Bundle size report
|
github-actions
bot
added
the
PR: out-of-date
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
added
PR: out-of-date
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
1 similar comment
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
removed
the
PR: out-of-date
rita-codes
reviewed
Nov 5, 2025
packages/x-scheduler-headless/src/event-calendar-selectors/eventCalendarEventSelectors.test.ts
Outdated
Show resolved
Hide resolved
rita-codes
approved these changes
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #19010
I introduced 2 small utilities to easily have fully functional tests.
When we test something that can be controlled by the parameters, I think it's more reliable that hardcoding the test changes.
When we test something that can't be controlled by the parameters (for example the placeholder), then at least we only have to override this part of the UI. But I think we could introduce other utilities in the future to help.
Not sure if we should also use the builder pattern for the whole state.
That could be interesting in the future to have something more powerful.