Skip to content

[DataGrid] Wait for external model updates before resetting pagination after sort/filter #20162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 3, 2025
Merged

[DataGrid] Wait for external model updates before resetting pagination after sort/filter #20162

merged 5 commits into from
Nov 3, 2025

Conversation

@arminmeh
Copy link
Contributor

@arminmeh arminmeh commented Oct 31, 2025 •
edited by MBilalShafi
Loading

Fixes #20114

Our internal event subscription caused a race condition in which the prop updates were overwritten with an old state + a partial update based on the event handler.

Demo: https://stackblitz.com/edit/rp9znfb2-jiwgmh4s

@arminmeh arminmeh added type: bug It doesn't behave as expected. scope: data grid Changes related to the data grid. feature: Pagination Related to the data grid Pagination feature feature: State management Related to the data grid State management feature labels Oct 31, 2025
@mui-bot
Copy link

mui-bot commented Oct 31, 2025 •
edited
Loading

Deploy preview: https://deploy-preview-20162--material-ui-x.netlify.app/

Bundle size report

Bundle Parsed size Gzip size
@mui/x-data-grid 🔺+29B(+0.01%) 🔺+24B(+0.02%)
@mui/x-data-grid-pro 🔺+29B(+0.01%) 🔺+1B(0.00%)
@mui/x-data-grid-premium 🔺+29B(0.00%) 🔺+11B(+0.01%)
@mui/x-charts 0B(0.00%) 0B(0.00%)
@mui/x-charts-pro 0B(0.00%) 0B(0.00%)
@mui/x-charts-premium 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers-pro 0B(0.00%) 0B(0.00%)
@mui/x-tree-view 0B(0.00%) 0B(0.00%)
@mui/x-tree-view-pro 0B(0.00%) 0B(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against 07b8776

@arminmeh arminmeh marked this pull request as draft October 31, 2025 14:21
@arminmeh arminmeh marked this pull request as ready for review October 31, 2025 15:52
@arminmeh arminmeh changed the title [DataGrid] Pagination does not react on sort and filter updates with controlled model [DataGrid] Wait for external model updates before resetting pagination after sort/filter Oct 31, 2025
@arminmeh arminmeh requested a review from cherniavskii October 31, 2025 15:53
@arminmeh arminmeh marked this pull request as draft October 31, 2025 19:14
@arminmeh arminmeh marked this pull request as ready for review October 31, 2025 19:33
@arminmeh arminmeh enabled auto-merge (squash) November 3, 2025 19:22
@arminmeh arminmeh merged commit 508f8eb into mui:master Nov 3, 2025
21 checks passed
@arminmeh arminmeh deleted the controlled-pagination-sort-filter branch November 4, 2025 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MBilalShafi MBilalShafi MBilalShafi approved these changes

@cherniavskii cherniavskii Awaiting requested review from cherniavskii

Assignees

No one assigned

Labels

feature: Pagination Related to the data grid Pagination feature feature: State management Related to the data grid State management feature scope: data grid Changes related to the data grid. type: bug It doesn't behave as expected.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[data grid] Page reset with change of filter model and sort model doesn't let me to reset the page size

4 participants

@arminmeh @mui-bot @MBilalShafi @cherniavskii