Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude esm folder from icons alias #2606

Merged
merged 3 commits into from
Sep 1, 2023
Merged

Exclude esm folder from icons alias #2606

merged 3 commits into from
Sep 1, 2023

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Sep 1, 2023

Haven't ran into this, but just to give the good example.

Also fixing tooltips on the NumberFormat property control that is used in the Metric component. (Saw this warning popping up while testing the other change)

MarkdownTooltip.tsx:32 Warning: Failed prop type: Invalid prop `children` supplied to `ForwardRef(Tooltip2)`. Expected an element that can hold a ref. Did you accidentally use a plain function component for an element instead? For more information see https://mui.com/r/caveat-with-refs-guide
    at Tooltip2 (http://localhost:3000/_toolpad/@fs/Users/janpotoms/Projects/toolpad/packages/toolpad-app/node_modules/.vite/deps/chunk-UYZY5CSJ.js?v=d7ee65a1:290:17)
    at MarkdownTooltip (http://localhost:3000/_toolpad/@fs/Users/janpotoms/Projects/toolpad/packages/toolpad-app/src/components/MarkdownTooltip.tsx:22:3)
    at PropertyControl (http://localhost:3000/_toolpad/@fs/Users/janpotoms/Projects/toolpad/packages/toolpad-app/src/components/PropertyControl.tsx:19:3)
    at GridColumnsPropEditor (http://localhost:3000/_toolpad/propertyControls/NumberFormat.tsx?t=1693561880565:20:3)
    ...

@Janpot Janpot added the core Infrastructure work going on behind the scenes label Sep 1, 2023
@Janpot Janpot marked this pull request as ready for review September 1, 2023 09:50
@Janpot Janpot requested a review from a team September 1, 2023 09:50
@Janpot Janpot merged commit 569aa83 into mui:master Sep 1, 2023
1 check passed
@Janpot Janpot deleted the fix-alias branch September 1, 2023 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants