-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: set default geometry value #139
base: master
Are you sure you want to change the base?
Conversation
Would need to ask for review from Yoshiki |
I want to improve this MR when I have time, but testing is tiresome, so I'm going to ensure building by #146 . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@felixvd @hemangandhi could you check if there are missing header initialization than |
it is almost 1 year. now it is in hurry. I filed |
I found that webstack geometry API does not return "visible" field always, which has to be interpreted as true.
As C++ does not have None value, the value is undefined. I saw something like 106 or 112, random.
This is the cause of test_planningsystem test_ObjectVisible flakiness.
@woswos @lazydroid There might be some other fields which might need to be filled as well, could you check?
/cc @felixvd @ntohge