Eliminate C array from members #140
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ran test in controllerclientcpppy MR. |
|
test looks ok |
|
i think this would need a minor version change |
|
I created this MR as I found difficulty maintaining controllerclientcpppy, but now it builds against both C-array and std::array using the same sourcecode, so maybe this MR is not even required... |
|
/cc @ntohge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
086bbd9 changed some arrays from C-Array to std::array. This pull request will convert rest arrays.
I confirmed that this controllerclientcpp revision builds at least.