Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to sensorSelectionInfos #25

Open
cielavenir opened this issue Oct 2, 2023 · 3 comments
Open

Migrate to sensorSelectionInfos #25

cielavenir opened this issue Oct 2, 2023 · 3 comments
Assignees
@felixvd @andriymujin

Comments

@cielavenir
Copy link
Contributor

cielavenir commented Oct 2, 2023 •
edited
Loading

Today I happened to know that https://github.com/mujin/mujinplanningclientpy/blob/master/python/mujinplanningclient/binpickingplanningclient.py#L354 IsRobotOccludingBody signature is different from current planningcommon realtimerobottask3.py's signature, where sensorSelectionInfos needs to be used, not cameraname.

There should be some others, so please check robottask and fix the planningclient signature accordingly.

/cc @ntohge
@andriymujin
Copy link
Contributor

I wander - how comes we only noticed it now? Was IsRobotOccludingBody never used before?

@cielavenir
Copy link
Contributor Author

@andriymujin maybe mujinsimulator is the only user

@andriymujin andriymujin self-assigned this Oct 3, 2023
@cielavenir
Copy link
Contributor Author

sent mujinsimulator side MR, can use that for total testing

@andriymujin andriymujin mentioned this issue Oct 3, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@felixvd felixvd

@andriymujin andriymujin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cielavenir @felixvd @andriymujin