fix: Migrate from cameraname to sensorSelectionInfo #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This migration is done without any consideration for backwards compatibility because cameraname was not a valid option on the server side for almost a year. So even if there are some users of the old API - they are already broken for a while.
|
CC: @cielavenir |
|
Please run autotester with this and the other branch |
Actually @cielavenir already triggered one: https://autotester.test.mujin.co.jp/?groupid=1&scheduleid=2&pipelineid=397923. Lets see. |
|
sorry @andriymujin could you resolve the conflict? |
|
after resolving conflict, please add ziyan as reviewer |
|
@ziyan PTAL. Planning client was using |
cielavenir
approved these changes
Oct 9, 2023
|
@ziyan Friendly ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This migration is done without any consideration for backwards compatibility because cameraname was not a valid option on the server side for almost a year. So even if there are some users of the old API - they are already broken for a while.
Issue: #25