Fix missing param manual recovery #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 27, 2023 11:53
… into fix-missing-param-manual-recovery
felixvd
reviewed
May 11, 2023
Comment on lines
+1
to
4
| # 0.1.1 (2023-04-27) | ||
|
|
||
| - Added missing param for manual placement recovery | ||
| - Port from mujincontrollerclientpy |
There was a problem hiding this comment.
The changelog needs to be in chronological order, so more like this:
Suggested change
| # 0.1.1 (2023-04-27) | |
| - Added missing param for manual placement recovery | |
| - Port from mujincontrollerclientpy | |
| # 0.1.4 (2023-04-27) | |
| - Added missing param for manual placement recovery | |
| # 0.1.0 (2022-11-17) | |
| - Port from mujincontrollerclientpy |
| @@ -576,7 +576,7 @@ def GetPackItemPoseInWorld(self, timeout=10, fireandforget=False, **kwargs): | |||
| taskparameters.update(kwargs) | |||
| return self.ExecuteCommand(taskparameters, timeout=timeout, fireandforget=fireandforget) | |||
|
|
|||
| def ManuallyPlacePackItem(self, packFormationComputationResult=None, inputPartIndex=None, placeLocationNames=None, placedTargetPrefix=None, dynamicGoalsGeneratorParameters=None, orderNumber=None, numLeftToPick=None, timeout=10, fireandforget=False): | |||
| def ManuallyPlacePackItem(self, packFormationComputationResult=None, inputPartIndex=None, placeLocationNames=None, placedTargetPrefix=None, dynamicGoalsGeneratorParameters=None, intMaxPackageTranslationOffsetXY=None, orderNumber=None, numLeftToPick=None, timeout=10, fireandforget=False): | |||
There was a problem hiding this comment.
Please add the parameter to the end so there is no breaking API change
felixvd
reviewed
May 11, 2023
|
Ping @tuialexandre |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding missing parameter related to Manual Recovery Placement