-
Notifications
You must be signed in to change notification settings - Fork 226
Use custom deserializer and apply masking in place #29
base: mule-4.x
Are you sure you want to change the base?
Use custom deserializer and apply masking in place #29
Conversation
this.enabled = enabled; | ||
|
||
blacklistedKeys = new HashSet<>(); | ||
blacklistedJsonPaths = new HashSet<>(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need for a path check. For one it is case sensitive, and secondly the same task can be accomplished using just the keys.
@jahanzebbaber : do you have write/maintain/admin permissions on this repo? I thought that this repo is now orphaned since @skuller no longer maintains it? |
@GeraldLoeffler I do not. We might end up just making this change to our internal GitHub organization if it is orphaned. |
@GeraldLoeffler @jahanzebbaber please reach out to @juancavallotti and @DavoCoder for ongoing requests! |
@skuller : please relax: there are no requests to you! |
@jahanzebbaber : in that case (you not having write permissions to this repo) can i please suggest that you open your Issues/PRs against this repo instead?: https://github.com/mulesoft-consulting/training-json-logger . This is a "fork" (not technically true/possible, because it's in the same GitHub org) of this repo and we have CI/CD pipelines in place to publish the JSON logger to the MuleSoft Training Exchange. We are using JSON logger in 2 of our courses, and plan to maintain our fork and the Exchange artifacts for the foreseeable future. So we're happy to merge your PRs over there if they work... |
@GeraldLoeffler thank you for the suggestion. I can raise this PR as is against the repo you mentioned. In its current state it fixes the performance bottleneck mentioned in #28. But if this repo is orphaned, I will probably remove everything that is not being used by our teams. |
thanks @jahanzebbaber , looking forward to your PR on our repo. As i said, our fork of the JSON logger is heavily used by our students and you're happy to use it too:
and
|
@GeraldLoeffler I just got around to raising the PR today. But I am getting a 404 while hitting https://github.com/mulesoft-consulting/training-json-logger. Thank you |
thank you very much @jahanzebbaber . You need to be authenticated against GitHub and in the https://github.com/orgs/mulesoft-consulting/teams/employees GitHub Team to be able to see https://github.com/mulesoft-consulting/training-json-logger . Are you? - every employee should be... |
@GeraldLoeffler I am not a Mulesoft employee. Sorry for the confusion. |
hey @jahanzebbaber : i've added you individually to that repo, you have Triage access now. Wouldn't want to miss your great contribution! Sorry for the back-and-forth ;) |
Fix for: #28