Separate ICMP reads from writes #5295
Annotations
3 errors and 21 warnings
Unit tests
error: Build input file cannot be found: '/Users/runner/work/mullvadvpn-app/mullvadvpn-app/ios/PacketTunnelCore/Pinger/Pinger.swift'. Did you forget to declare this file as an output of a script phase or custom build rule which produces it? (in target 'PacketTunnelCore' from project 'MullvadVPN')
|
Unit tests
error: Build input file cannot be found: '/Users/runner/work/mullvadvpn-app/mullvadvpn-app/ios/PacketTunnelCore/Pinger/Pinger.swift'. Did you forget to declare this file as an output of a script phase or custom build rule which produces it? (in target 'PacketTunnelCore' from project 'MullvadVPN')
|
Unit tests
Process completed with exit code 65.
|
Run swiftlint
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
Run swiftlint
swiftlint 0.57.0 is already installed and up-to-date.
To reinstall 0.57.0, run:
brew reinstall swiftlint
|
Run swiftlint:
MullvadSettings/SettingsManager.swift#L50
Prefer failable `String(data:encoding:)` initializer when converting `Data` to `String` (optional_data_string_conversion)
|
Run swiftlint:
Shared/LaunchArguments.swift#L49
Prefer failable `String(data:encoding:)` initializer when converting `Data` to `String` (optional_data_string_conversion)
|
Run swiftlint:
MullvadVPN/Classes/ConsolidatedApplicationLog.swift#L131
Prefer failable `String(data:encoding:)` initializer when converting `Data` to `String` (optional_data_string_conversion)
|
Run swiftlint:
MullvadVPN/View controllers/VPNSettings/VPNSettingsViewController.swift#L132
SwiftLint rule 'function_body_length' did not trigger a violation in the disabled region; remove the disable command (superfluous_disable_command)
|
Check formatting
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
Check formatting
swiftformat 0.54.5 already installed
|
Unit tests
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/cache@v3, actions/setup-go@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
Unit tests:
--- xcodebuild#L1
Using the first of multiple matching destinations:
|
Unit tests:
ios/.spm/checkouts/wireguard-apple/Sources/WireGuardKit/WireGuardAdapter.swift#L606
@discardableResult declared on a function returning Void is unnecessary
|
Unit tests:
ios/.spm/checkouts/wireguard-apple/Sources/WireGuardKit/WireGuardAdapter.swift#L606
@discardableResult declared on a function returning Void is unnecessary
|
Unit tests:
Users/runner/Library/Developer/Xcode/DerivedData/MullvadVPN-eyvrfmadodhkonbxvnjzkuyudpjl/Build/Intermediates.noindex/MullvadVPN.build/Debug-iphonesimulator/MullvadRustRuntime.build/module.private.modulemap#L1
expected canonical name for private module 'MullvadRustRuntimeProxy'
|
Unit tests:
Users/runner/Library/Developer/Xcode/DerivedData/MullvadVPN-eyvrfmadodhkonbxvnjzkuyudpjl/Build/Intermediates.noindex/MullvadVPN.build/Debug-iphonesimulator/MullvadRustRuntime.build/module.private.modulemap#L1
expected canonical name for private module 'MullvadRustRuntimeProxy'
|
Unit tests:
Users/runner/Library/Developer/Xcode/DerivedData/MullvadVPN-eyvrfmadodhkonbxvnjzkuyudpjl/Build/Intermediates.noindex/MullvadVPN.build/Debug-iphonesimulator/MullvadRustRuntime.build/module.private.modulemap#L1
expected canonical name for private module 'MullvadRustRuntimeProxy' [-Wprivate-module]
|
Unit tests:
Users/runner/Library/Developer/Xcode/DerivedData/MullvadVPN-eyvrfmadodhkonbxvnjzkuyudpjl/Build/Intermediates.noindex/MullvadVPN.build/Debug-iphonesimulator/MullvadRustRuntime.build/module.private.modulemap#L1
expected canonical name for private module 'MullvadRustRuntimeProxy'
|
Unit tests:
Users/runner/Library/Developer/Xcode/DerivedData/MullvadVPN-eyvrfmadodhkonbxvnjzkuyudpjl/Build/Intermediates.noindex/MullvadVPN.build/Debug-iphonesimulator/MullvadRustRuntime.build/module.private.modulemap#L1
expected canonical name for private module 'MullvadRustRuntimeProxy'
|
Unit tests:
Users/runner/Library/Developer/Xcode/DerivedData/MullvadVPN-eyvrfmadodhkonbxvnjzkuyudpjl/Build/Intermediates.noindex/MullvadVPN.build/Debug-iphonesimulator/MullvadRustRuntime.build/module.private.modulemap#L1
expected canonical name for private module 'MullvadRustRuntimeProxy'
|
Unit tests:
Users/runner/Library/Developer/Xcode/DerivedData/MullvadVPN-eyvrfmadodhkonbxvnjzkuyudpjl/Build/Intermediates.noindex/MullvadVPN.build/Debug-iphonesimulator/MullvadRustRuntime.build/module.private.modulemap#L1
expected canonical name for private module 'MullvadRustRuntimeProxy'
|
Unit tests
xcbeautify 2.11.0 is already installed and up-to-date.
To reinstall 2.11.0, run:
brew reinstall xcbeautify
|
Unit tests
Failed to restore: Cache service responded with 429
|