iOS app

Add info modals to default access methods screens #5298

Triggered via pull request October 2, 2024 10:14

rablador

synchronize #6905

change-encrypted-dns-proxy-info-text-copy-ios-849

Status Success

Total duration 7m 13s

Billable time 7m

Artifacts –

ios.yml

on: pull_request

Annotations

20 warnings

Run swiftlint

The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

Run swiftlint

swiftlint 0.57.0 is already installed and up-to-date. To reinstall 0.57.0, run: brew reinstall swiftlint

Run swiftlint: MullvadSettings/SettingsManager.swift#L50

Prefer failable `String(data:encoding:)` initializer when converting `Data` to `String` (optional_data_string_conversion)

Run swiftlint: Shared/LaunchArguments.swift#L49

Prefer failable `String(data:encoding:)` initializer when converting `Data` to `String` (optional_data_string_conversion)

Run swiftlint: MullvadVPN/Coordinators/Settings/APIAccess/Edit/EditAccessMethodViewController.swift#L407

File should contain 400 lines or less: currently contains 407 (file_length)

Run swiftlint: MullvadVPN/Classes/ConsolidatedApplicationLog.swift#L131

Prefer failable `String(data:encoding:)` initializer when converting `Data` to `String` (optional_data_string_conversion)

Check formatting

swiftformat 0.54.5 already installed

Unit tests

The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/cache@v3, actions/setup-go@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

Unit tests: --- xcodebuild#L1

Using the first of multiple matching destinations:

Unit tests: ios/.spm/checkouts/wireguard-apple/Sources/WireGuardKitGo/wireguard.h#L29

umbrella header for module 'WireGuardKitGo' does not include header '/wireguard-go/maybenot/crates/maybenot-ffi/maybenot.h'

Unit tests: Users/runner/Library/Developer/Xcode/DerivedData/MullvadVPN-eyvrfmadodhkonbxvnjzkuyudpjl/Build/Intermediates.noindex/MullvadVPN.build/Debug-iphonesimulator/MullvadRustRuntime.build/module.private.modulemap#L1

expected canonical name for private module 'MullvadRustRuntimeProxy'

expected canonical name for private module 'MullvadRustRuntimeProxy' [-Wprivate-module]

expected canonical name for private module 'MullvadRustRuntimeProxy'

Unit tests

xcbeautify 2.11.0 is already installed and up-to-date. To reinstall 2.11.0, run: brew reinstall xcbeautify

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add info modals to default access methods screens #5298

Summary