Skip to content
iOS app

Increase touch target size the 'log out device' button #5319

Sign in to view logs

Increase touch target size the 'log out device' button

Increase touch target size the 'log out device' button #5319

Triggered via pull request October 4, 2024 13:34
@rabladorrablador
opened #6926
increase-touch-target-size-the-_log-out-device_-button-in-ios-857
Status Success
Total duration 6m 12s
Billable time 7m
Artifacts –

ios.yml

on: pull_request
Check formatting
36s
Check formatting
Run swiftlint
37s
Run swiftlint
Unit tests
6m 2s
Unit tests
Fit to window
Zoom out
Zoom in

Annotations

19 warnings
Check formatting
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Check formatting
swiftformat 0.54.5 already installed
Run swiftlint
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Run swiftlint
swiftlint 0.57.0 is already installed and up-to-date. To reinstall 0.57.0, run: brew reinstall swiftlint
Run swiftlint: MullvadSettings/SettingsManager.swift#L50
Prefer failable `String(data:encoding:)` initializer when converting `Data` to `String` (optional_data_string_conversion)
Run swiftlint: Shared/LaunchArguments.swift#L49
Prefer failable `String(data:encoding:)` initializer when converting `Data` to `String` (optional_data_string_conversion)
Run swiftlint: MullvadVPN/Classes/ConsolidatedApplicationLog.swift#L131
Prefer failable `String(data:encoding:)` initializer when converting `Data` to `String` (optional_data_string_conversion)
Unit tests
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/cache@v3, actions/setup-go@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Unit tests: --- xcodebuild#L1
Using the first of multiple matching destinations:
Unit tests: ios/.spm/checkouts/wireguard-apple/Sources/WireGuardKitGo/wireguard.h#L30
umbrella header for module 'WireGuardKitGo' does not include header '/wireguard-go/maybenot/crates/maybenot-ffi/maybenot.h'
Unit tests: ios/.spm/checkouts/wireguard-apple/Sources/WireGuardKit/WireGuardAdapter.swift#L606
@discardableResult declared on a function returning Void is unnecessary
Unit tests: ios/.spm/checkouts/wireguard-apple/Sources/WireGuardKit/WireGuardAdapter.swift#L606
@discardableResult declared on a function returning Void is unnecessary
Unit tests: Users/runner/Library/Developer/Xcode/DerivedData/MullvadVPN-eyvrfmadodhkonbxvnjzkuyudpjl/Build/Intermediates.noindex/MullvadVPN.build/Debug-iphonesimulator/MullvadRustRuntime.build/module.private.modulemap#L1
expected canonical name for private module 'MullvadRustRuntimeProxy'
Unit tests: Users/runner/Library/Developer/Xcode/DerivedData/MullvadVPN-eyvrfmadodhkonbxvnjzkuyudpjl/Build/Intermediates.noindex/MullvadVPN.build/Debug-iphonesimulator/MullvadRustRuntime.build/module.private.modulemap#L1
expected canonical name for private module 'MullvadRustRuntimeProxy'
Unit tests: Users/runner/Library/Developer/Xcode/DerivedData/MullvadVPN-eyvrfmadodhkonbxvnjzkuyudpjl/Build/Intermediates.noindex/MullvadVPN.build/Debug-iphonesimulator/MullvadRustRuntime.build/module.private.modulemap#L1
expected canonical name for private module 'MullvadRustRuntimeProxy' [-Wprivate-module]
Unit tests: Users/runner/Library/Developer/Xcode/DerivedData/MullvadVPN-eyvrfmadodhkonbxvnjzkuyudpjl/Build/Intermediates.noindex/MullvadVPN.build/Debug-iphonesimulator/MullvadRustRuntime.build/module.private.modulemap#L1
expected canonical name for private module 'MullvadRustRuntimeProxy'
Unit tests: Users/runner/Library/Developer/Xcode/DerivedData/MullvadVPN-eyvrfmadodhkonbxvnjzkuyudpjl/Build/Intermediates.noindex/MullvadVPN.build/Debug-iphonesimulator/MullvadRustRuntime.build/module.private.modulemap#L1
expected canonical name for private module 'MullvadRustRuntimeProxy'
Unit tests: Users/runner/Library/Developer/Xcode/DerivedData/MullvadVPN-eyvrfmadodhkonbxvnjzkuyudpjl/Build/Intermediates.noindex/MullvadVPN.build/Debug-iphonesimulator/MullvadRustRuntime.build/module.private.modulemap#L1
expected canonical name for private module 'MullvadRustRuntimeProxy'
Unit tests
xcbeautify 2.11.0 is already installed and up-to-date. To reinstall 2.11.0, run: brew reinstall xcbeautify