Skip to content

Fix screenshot tests failing #4920

Fix screenshot tests failing

Fix screenshot tests failing #4920

Triggered via pull request June 13, 2024 16:04
Status Success
Total duration 5m 41s
Billable time 6m
Artifacts

ios.yml

on: pull_request
Check formatting
36s
Check formatting
Run swiftlint
38s
Run swiftlint
Unit tests
5m 31s
Unit tests
Fit to window
Zoom out
Zoom in

Annotations

24 warnings
Check formatting
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Run swiftlint
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Run swiftlint
swiftlint 0.55.1 is already installed and up-to-date. To reinstall 0.55.1, run: brew reinstall swiftlint
Run swiftlint: PacketTunnel/PacketTunnelProvider/PacketTunnelProvider.swift#L36
Function body should span 50 lines or less excluding comments and whitespace: currently spans 54 lines (function_body_length)
Run swiftlint: MullvadSettings/SettingsManager.swift#L51
Prefer using UTF-8 encoded strings when converting between `String` and `Data` (non_optional_string_data_conversion)
Run swiftlint: MullvadVPNUITests/Screenshots/SnapshotHelper.swift#L213
Unused parameter in a closure should be replaced with _ (unused_closure_parameter)
Run swiftlint: MullvadVPNTests/MullvadSettings/IPOverrideRepositoryTests.swift#L17
Prefer `static` over `final class` (static_over_final_class)
Run swiftlint: MullvadVPNTests/MullvadSettings/IPOverrideRepositoryTests.swift#L21
Prefer `static` over `final class` (static_over_final_class)
Run swiftlint: MullvadVPNTests/MullvadSettings/MigrationManagerTests.swift#L74
Prefer using UTF-8 encoded strings when converting between `String` and `Data` (non_optional_string_data_conversion)
Run swiftlint: MullvadVPNTests/MullvadSettings/MigrationManagerTests.swift#L18
Prefer `static` over `final class` (static_over_final_class)
Run swiftlint: MullvadVPNTests/MullvadSettings/MigrationManagerTests.swift#L22
Prefer `static` over `final class` (static_over_final_class)
Run swiftlint: MullvadVPNTests/MullvadSettings/APIAccessMethodsTests.swift#L16
Prefer `static` over `final class` (static_over_final_class)
Unit tests
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/cache@v3, actions/setup-go@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Unit tests: --- xcodebuild#L1
Using the first of multiple matching destinations:
Unit tests
/Users/runner/work/mullvadvpn-app/mullvadvpn-app/mullvad-jni/Cargo.toml: `crate_type` is deprecated in favor of `crate-type` and will not work in the 2024 edition
Unit tests
/Users/runner/work/mullvadvpn-app/mullvadvpn-app/mullvad-nsis/Cargo.toml: `crate_type` is deprecated in favor of `crate-type` and will not work in the 2024 edition
Unit tests
/Users/runner/work/mullvadvpn-app/mullvadvpn-app/mullvad-jni/Cargo.toml: `crate_type` is deprecated in favor of `crate-type` and will not work in the 2024 edition
Unit tests
/Users/runner/work/mullvadvpn-app/mullvadvpn-app/mullvad-nsis/Cargo.toml: `crate_type` is deprecated in favor of `crate-type` and will not work in the 2024 edition
Unit tests
/Users/runner/work/mullvadvpn-app/mullvadvpn-app/mullvad-jni/Cargo.toml: `crate_type` is deprecated in favor of `crate-type` and will not work in the 2024 edition
Unit tests
/Users/runner/work/mullvadvpn-app/mullvadvpn-app/mullvad-nsis/Cargo.toml: `crate_type` is deprecated in favor of `crate-type` and will not work in the 2024 edition
Unit tests
/Users/runner/work/mullvadvpn-app/mullvadvpn-app/mullvad-jni/Cargo.toml: `crate_type` is deprecated in favor of `crate-type` and will not work in the 2024 edition
Unit tests
/Users/runner/work/mullvadvpn-app/mullvadvpn-app/mullvad-nsis/Cargo.toml: `crate_type` is deprecated in favor of `crate-type` and will not work in the 2024 edition
Unit tests
/Users/runner/work/mullvadvpn-app/mullvadvpn-app/mullvad-nsis/Cargo.toml: `crate_type` is deprecated in favor of `crate-type` and will not work in the 2024 edition
Unit tests
xcbeautify 2.3.1 is already installed and up-to-date. To reinstall 2.3.1, run: brew reinstall xcbeautify