Remove all complexity to do with iPad UI #4930
rabladorAnnotations
20 warnings and 1 notice
|
Run swiftlint
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
Run swiftlint
swiftlint 0.55.1 is already installed and up-to-date.
To reinstall 0.55.1, run:
brew reinstall swiftlint
|
|
Run swiftlint:
PacketTunnel/PacketTunnelProvider/PacketTunnelProvider.swift#L36
Function body should span 50 lines or less excluding comments and whitespace: currently spans 54 lines (function_body_length)
|
|
Run swiftlint:
MullvadSettings/SettingsManager.swift#L51
Prefer using UTF-8 encoded strings when converting between `String` and `Data` (non_optional_string_data_conversion)
|
|
Run swiftlint:
MullvadVPNUITests/Screenshots/SnapshotHelper.swift#L213
Unused parameter in a closure should be replaced with _ (unused_closure_parameter)
|
|
Run swiftlint:
MullvadVPNTests/MullvadSettings/IPOverrideRepositoryTests.swift#L17
Prefer `static` over `final class` (static_over_final_class)
|
|
Run swiftlint:
MullvadVPNTests/MullvadSettings/IPOverrideRepositoryTests.swift#L21
Prefer `static` over `final class` (static_over_final_class)
|
|
Run swiftlint:
MullvadVPNTests/MullvadSettings/MigrationManagerTests.swift#L74
Prefer using UTF-8 encoded strings when converting between `String` and `Data` (non_optional_string_data_conversion)
|
|
Run swiftlint:
MullvadVPNTests/MullvadSettings/MigrationManagerTests.swift#L18
Prefer `static` over `final class` (static_over_final_class)
|
|
Run swiftlint:
MullvadVPNTests/MullvadSettings/MigrationManagerTests.swift#L22
Prefer `static` over `final class` (static_over_final_class)
|
|
Run swiftlint:
MullvadVPNTests/MullvadSettings/APIAccessMethodsTests.swift#L16
Prefer `static` over `final class` (static_over_final_class)
|
|
Check formatting
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
Unit tests
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/cache@v3, actions/setup-go@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
Unit tests:
--- xcodebuild#L1
Using the first of multiple matching destinations:
|
|
Unit tests
SwiftLint not installed, download from https://github.com/realm/SwiftLint
|
|
Unit tests:
ld#L1
'/Users/runner/Library/Developer/Xcode/DerivedData/MullvadVPN-eyvrfmadodhkonbxvnjzkuyudpjl/Build/Products/Debug-iphonesimulator/libwg-go.a[arm64][2](go.o)' has malformed LC_DYSYMTAB, expected 61 undefined symbols to start at index 4702, found 73 undefined symbols starting at index 15
|
|
Unit tests
SwiftLint not installed, download from https://github.com/realm/SwiftLint
|
|
Unit tests:
ios/MullvadVPN/Coordinators/ApplicationCoordinator.swift#L261
variable 'nextRoutes' was never mutated; consider changing to 'let' constant
|
|
Unit tests
xcbeautify 2.3.1 is already installed and up-to-date.
To reinstall 2.3.1, run:
brew reinstall xcbeautify
|
|
Unit tests
Failed to restore: Cache service responded with 429
|
|
Unit tests
Tests Passed: 0 failed, 0 skipped, 3 total (0.844 seconds)
|