Replace all maximum timeout values to 60 seconds #4951
rabladorAnnotations
2 errors and 15 warnings
|
Unit tests:
ios/OperationsTests/OperationConditionTests.swift#L9
no such module 'MullvadMockData'
|
|
Unit tests
Process completed with exit code 65.
|
|
Run swiftlint
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
Run swiftlint
swiftlint 0.55.1 is already installed and up-to-date.
To reinstall 0.55.1, run:
brew reinstall swiftlint
|
|
Run swiftlint:
PacketTunnel/PacketTunnelProvider/PacketTunnelProvider.swift#L36
Function body should span 50 lines or less excluding comments and whitespace: currently spans 54 lines (function_body_length)
|
|
Run swiftlint:
MullvadSettings/SettingsManager.swift#L51
Prefer using UTF-8 encoded strings when converting between `String` and `Data` (non_optional_string_data_conversion)
|
|
Run swiftlint:
MullvadVPNTests/MullvadSettings/IPOverrideRepositoryTests.swift#L17
Prefer `static` over `final class` (static_over_final_class)
|
|
Run swiftlint:
MullvadVPNTests/MullvadSettings/IPOverrideRepositoryTests.swift#L21
Prefer `static` over `final class` (static_over_final_class)
|
|
Run swiftlint:
MullvadVPNTests/MullvadSettings/MigrationManagerTests.swift#L75
Prefer using UTF-8 encoded strings when converting between `String` and `Data` (non_optional_string_data_conversion)
|
|
Run swiftlint:
MullvadVPNTests/MullvadSettings/MigrationManagerTests.swift#L19
Prefer `static` over `final class` (static_over_final_class)
|
|
Run swiftlint:
MullvadVPNTests/MullvadSettings/MigrationManagerTests.swift#L23
Prefer `static` over `final class` (static_over_final_class)
|
|
Run swiftlint:
MullvadVPNTests/MullvadSettings/APIAccessMethodsTests.swift#L16
Prefer `static` over `final class` (static_over_final_class)
|
|
Run swiftlint:
MullvadVPNTests/MullvadSettings/APIAccessMethodsTests.swift#L20
Prefer `static` over `final class` (static_over_final_class)
|
|
Check formatting
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
Check formatting
swiftformat 0.54.0 already installed
|
|
Unit tests
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/cache@v3, actions/setup-go@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
Unit tests:
--- xcodebuild#L1
Using the first of multiple matching destinations:
|