Move ICMP packet creation and parsing out of Pinger implementation #4994
Annotations
11 warnings
|
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
|
|
PacketTunnel/PacketTunnelProvider/PacketTunnelProvider.swift#L36
Function body should span 50 lines or less excluding comments and whitespace: currently spans 54 lines (function_body_length)
|
|
MullvadSettings/SettingsManager.swift#L51
Prefer using UTF-8 encoded strings when converting between `String` and `Data` (non_optional_string_data_conversion)
|
|
MullvadVPNTests/MullvadSettings/IPOverrideRepositoryTests.swift#L17
Prefer `static` over `final class` (static_over_final_class)
|
|
MullvadVPNTests/MullvadSettings/IPOverrideRepositoryTests.swift#L21
Prefer `static` over `final class` (static_over_final_class)
|
|
MullvadVPNTests/MullvadSettings/MigrationManagerTests.swift#L75
Prefer using UTF-8 encoded strings when converting between `String` and `Data` (non_optional_string_data_conversion)
|
|
MullvadVPNTests/MullvadSettings/MigrationManagerTests.swift#L19
Prefer `static` over `final class` (static_over_final_class)
|
|
MullvadVPNTests/MullvadSettings/MigrationManagerTests.swift#L23
Prefer `static` over `final class` (static_over_final_class)
|
|
MullvadVPNTests/MullvadSettings/APIAccessMethodsTests.swift#L16
Prefer `static` over `final class` (static_over_final_class)
|
|
MullvadVPNTests/MullvadSettings/APIAccessMethodsTests.swift#L20
Prefer `static` over `final class` (static_over_final_class)
|
This job succeeded
Loading