Skip to content

Commit

Permalink
Run screenshots action on Github
Browse files Browse the repository at this point in the history
  • Loading branch information
Jon Petersson committed Dec 7, 2023
1 parent df3262c commit 2e3b9b9
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 7 deletions.
23 changes: 21 additions & 2 deletions .github/workflows/ios.yml
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ jobs:
runs-on: macos-13-xlarge
env:
SOURCE_PACKAGES_PATH: .spm
TEST_ACCOUNT: ${{ secrets.IOS_TEST_ACCOUNT_NUMBER }}
steps:
- name: Checkout repository
uses: actions/checkout@v3
Expand Down Expand Up @@ -83,17 +84,35 @@ jobs:
cp Screenshots.xcconfig.template Screenshots.xcconfig
working-directory: ios/Configurations

# - name: Bundle
# run: bundle install
# working-directory: ios

- name: Install xcbeautify
run: |
brew update
brew install xcbeautify
- name: Run tests
# - name: Run tests
# run: |
# set -o pipefail && env NSUnbufferedIO=YES xcodebuild \
# -project MullvadVPN.xcodeproj \
# -scheme MullvadVPN \
# -testPlan MullvadVPNCI \
# -destination "platform=iOS Simulator,name=iPhone 15" \
# -clonedSourcePackagesDirPath "$SOURCE_PACKAGES_PATH" \
# test 2>&1 | xcbeautify
# working-directory: ios/

- name: Run screenshots
# run: bundle exec fastlane snapshot
run: |
sed -i "" "s/MULLVAD_ACCOUNT_TOKEN = /MULLVAD_ACCOUNT_TOKEN = $TEST_ACCOUNT/g" Configurations/Screenshots.xcconfig

Check failure on line 110 in .github/workflows/ios.yml

View workflow job for this annotation

GitHub Actions / check-formatting

110:121 [line-length] line too long (124 > 120 characters)
cat Configurations/Screenshots.xcconfig
set -o pipefail && env NSUnbufferedIO=YES xcodebuild \
-project MullvadVPN.xcodeproj \
-scheme MullvadVPN \
-testPlan MullvadVPNCI \
-testPlan MullvadVPNScreenshots \
-destination "platform=iOS Simulator,name=iPhone 15" \
-clonedSourcePackagesDirPath "$SOURCE_PACKAGES_PATH" \
test 2>&1 | xcbeautify
Expand Down
6 changes: 1 addition & 5 deletions ios/Snapfile
Original file line number Diff line number Diff line change
@@ -1,10 +1,6 @@
# A list of devices you want to take the screenshots from
devices([
"iPhone 8 Plus", # 5.5"
"iPhone 11 Pro Max", # 6.5"
"iPhone 14 Pro Max", # 6.7"
"iPad Pro (12.9-inch) (2nd generation)",
"iPad Pro (12.9-inch) (6th generation)"
"iPhone 14"
])

languages([
Expand Down

0 comments on commit 2e3b9b9

Please sign in to comment.