Skip to content

Commit

Permalink
Fix false negative in github action
Browse files Browse the repository at this point in the history
Add a precondition to all os-specific test steps in the desktop
end-to-end test github action which checks if there are any vms to test
for the given os. . Without this check, the parsing of the vm names
assumed that there would exist atleast 1, causing the parsing to fail if
there were none. This would show up in the GitHub summary view as a
failure, while the intention was for it to be a noop.
  • Loading branch information
MarkusPettersson98 committed Jul 23, 2024
1 parent a16537e commit 2f9a72f
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/desktop-e2e.yml
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ jobs:
e2e-test-linux:
name: Linux end-to-end tests
needs: [prepare-matrices, build-linux]
if: '!cancelled()'
if: !cancelled() && (needs.prepare-matrices.outputs.linux_matrix != '[]' && needs.prepare-matrices.outputs.linux_matrix != '')
runs-on: [self-hosted, desktop-test, Linux] # app-test-linux
timeout-minutes: 240
strategy:
Expand Down Expand Up @@ -196,7 +196,7 @@ jobs:

e2e-test-windows:
needs: [prepare-matrices, build-windows]
if: '!cancelled()'
if: !cancelled() && (needs.prepare-matrices.outputs.windows_matrix != '[]' && needs.prepare-matrices.outputs.windows_matrix != '')
name: Windows end-to-end tests
runs-on: [self-hosted, desktop-test, Linux] # app-test-linux
timeout-minutes: 240
Expand Down Expand Up @@ -263,7 +263,7 @@ jobs:
e2e-test-macos:
needs: [prepare-matrices, build-macos]
if: '!cancelled()'
if: !cancelled() && (needs.prepare-matrices.outputs.macos_matrix != '[]' && needs.prepare-matrices.outputs.macos_matrix != '')
name: macOS end-to-end tests
runs-on: [self-hosted, desktop-test, macOS] # app-test-macos-arm
timeout-minutes: 240
Expand Down

0 comments on commit 2f9a72f

Please sign in to comment.