Update screenshots test to work with updated UI

mullvad · Sep 18, 2023 · 8896268 · 8896268
1 parent 0d95c88
commit 8896268
Show file tree

Hide file tree

Showing 9 changed files with 14 additions and 70 deletions.
diff --git a/ios/MullvadVPN.xcodeproj/project.pbxproj b/ios/MullvadVPN.xcodeproj/project.pbxproj
@@ -2581,9 +2581,9 @@
 		7A83C3FC2A55B39500DFB83A /* TestPlans */ = {
 			isa = PBXGroup;
 			children = (
-				7A02D4EA2A9CEC7A00C19E31 /* MullvadVPNScreenshots.xctestplan */,
 				7A83C3FE2A55B72E00DFB83A /* MullvadVPNApp.xctestplan */,
 				7A83C4002A55B81A00DFB83A /* MullvadVPNCI.xctestplan */,
+				7A02D4EA2A9CEC7A00C19E31 /* MullvadVPNScreenshots.xctestplan */,
 			);
 			path = TestPlans;
 			sourceTree = "<group>";

diff --git a/ios/MullvadVPN/Coordinators/AccountCoordinator.swift b/ios/MullvadVPN/Coordinators/AccountCoordinator.swift
@@ -136,6 +136,7 @@ final class AccountCoordinator: Coordinator, Presentable, Presenting {
         let presentation = AlertPresentation(
             id: "account-logout-alert",
             icon: .spinner,
+            message: nil,
             buttons: []
         )
 

diff --git a/ios/MullvadVPN/Coordinators/AlertCoordinator.swift b/ios/MullvadVPN/Coordinators/AlertCoordinator.swift
@@ -39,7 +39,12 @@ final class AlertCoordinator: Coordinator, Presentable {
         }
 
         presentation.buttons.forEach { action in
-            alertController.addAction(title: action.title, style: action.style, handler: action.handler)
+            alertController.addAction(
+                title: action.title,
+                style: action.style,
+                accessibilityId: action.accessibilityID,
+                handler: action.handler
+            )
         }
     }
 }
diff --git a/ios/MullvadVPN/Coordinators/ApplicationCoordinator.swift b/ios/MullvadVPN/Coordinators/ApplicationCoordinator.swift
@@ -1008,10 +1008,3 @@ fileprivate extension AppPreferencesDataSource {
 
     // swiftlint:disable:next file_length
 }
-
-private protocol Poppable: Presentable {
-    func popFromNavigationStack(
-        animated: Bool,
-        completion: () -> Void
-    )
-}
diff --git a/ios/MullvadVPN/Coordinators/ChangeLogCoordinator.swift b/ios/MullvadVPN/Coordinators/ChangeLogCoordinator.swift
@@ -38,6 +38,7 @@ final class ChangeLogCoordinator: Coordinator, Presentable {
                 comment: ""
             ),
             style: .default,
+            accessibilityId: "OkButton",
             handler: { [weak self] in
                 guard let self else { return }
                 didFinish?(self)

diff --git a/ios/MullvadVPN/Operations/PresentAlertOperation.swift b/ios/MullvadVPN/Operations/PresentAlertOperation.swift
diff --git a/ios/MullvadVPN/View controllers/Alert/AlertPresentation.swift b/ios/MullvadVPN/View controllers/Alert/AlertPresentation.swift
@@ -17,6 +17,7 @@ struct AlertMetadata {
 struct AlertAction {
     let title: String
     let style: AlertActionStyle
+    var accessibilityID: String?
     var handler: (() -> Void)?
 }
 

diff --git a/ios/MullvadVPN/View controllers/Alert/AlertViewController.swift b/ios/MullvadVPN/View controllers/Alert/AlertViewController.swift
@@ -120,14 +120,15 @@ class AlertViewController: UIViewController {
         }
     }
 
-    func addAction(title: String, style: AlertActionStyle, handler: (() -> Void)? = nil) {
+    func addAction(title: String, style: AlertActionStyle, accessibilityId: String?, handler: (() -> Void)? = nil) {
         // The presence of a button should reset any custom button margin to default.
         containerView.directionalLayoutMargins.bottom = UIMetrics.CustomAlert.containerMargins.bottom
 
         let button = AppButton(style: style.buttonStyle)
 
-        button.addTarget(self, action: #selector(didTapButton), for: .touchUpInside)
         button.setTitle(title, for: .normal)
+        button.accessibilityIdentifier = accessibilityId
+        button.addTarget(self, action: #selector(didTapButton), for: .touchUpInside)
 
         containerView.addArrangedSubview(button)
         handler.flatMap { handlers[button] = $0 }

diff --git a/ios/MullvadVPNScreenshots/MullvadVPNScreenshots.swift b/ios/MullvadVPNScreenshots/MullvadVPNScreenshots.swift
@@ -71,6 +71,7 @@ class MullvadVPNScreenshots: XCTestCase {
         if cityCell.exists {
             cityCell.tap()
         } else {
+            _ = countryCell.buttons["CollapseButton"].waitForExistence(timeout: 5)
             countryCell.buttons["CollapseButton"].tap()
             cityCell.tap()
         }