Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Swiftlint warnings in RootContainerViewController #5105

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Fix Swiftlint warnings in RootContainerViewController #5105

merged 1 commit into from
Sep 12, 2023

Conversation

rablador
Copy link
Contributor

@rablador rablador commented Sep 5, 2023 •
edited by faern
Loading

This change is Reviewable

rablador
rablador commented Sep 5, 2023
View reviewed changes
Copy link
Contributor Author

@rablador rablador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactoring to fix lint error function_body_length and/or cyclomatic_complexity.

Reviewable status: 0 of 1 files reviewed, all discussions resolved

@rablador rablador force-pushed the fix-swiftlint-warnings-in-xcode-ios-RootContainerViewController-296 branch from 24f6567 to 030515b Compare September 5, 2023 10:39
@rablador rablador added the iOS Issues related to iOS label Sep 5, 2023
@buggmagnet buggmagnet self-requested a review September 12, 2023 12:11
@rablador rablador requested a review from mojganii September 12, 2023 12:34
buggmagnet
buggmagnet approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@buggmagnet buggmagnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, all discussions resolved

@buggmagnet buggmagnet force-pushed the fix-swiftlint-warnings-in-xcode-ios-RootContainerViewController-296 branch from 030515b to 4ecd728 Compare September 12, 2023 12:49
@buggmagnet buggmagnet merged commit b952fff into main Sep 12, 2023
@buggmagnet buggmagnet deleted the fix-swiftlint-warnings-in-xcode-ios-RootContainerViewController-296 branch September 12, 2023 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@buggmagnet buggmagnet buggmagnet approved these changes

@mojganii mojganii Awaiting requested review from mojganii

Assignees
No one assigned
Labels
iOS Issues related to iOS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rablador @buggmagnet