Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Swiftlint warnings in TunnelMonitor #5112

Merged

Conversation

rablador
Copy link
Contributor

@rablador rablador commented Sep 5, 2023


This change is Reviewable

Copy link
Contributor Author

@rablador rablador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactoring to fix lint error function_body_length and/or cyclomatic_complexity.

Reviewable status: 0 of 1 files reviewed, all discussions resolved

@rablador rablador force-pushed the fix-swiftlint-warnings-in-xcode-ios-TunnelMonitor-296 branch from 41acb8c to ac895a1 Compare September 5, 2023 10:45
@rablador rablador added the iOS Issues related to iOS label Sep 5, 2023
@rablador rablador force-pushed the fix-swiftlint-warnings-in-xcode-ios-TunnelMonitor-296 branch from ac895a1 to b8573f3 Compare September 5, 2023 11:04
Copy link
Collaborator

@mojganii mojganii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 1 files reviewed, all discussions resolved

@buggmagnet buggmagnet force-pushed the fix-swiftlint-warnings-in-xcode-ios-TunnelMonitor-296 branch from b8573f3 to 9f981c1 Compare September 11, 2023 11:24
@rablador rablador requested a review from buggmagnet September 12, 2023 12:34
Copy link
Contributor

@pronebird pronebird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@buggmagnet buggmagnet force-pushed the fix-swiftlint-warnings-in-xcode-ios-TunnelMonitor-296 branch from 9f981c1 to a3d4328 Compare September 13, 2023 07:47
@buggmagnet buggmagnet merged commit 92bd76e into main Sep 13, 2023
@buggmagnet buggmagnet deleted the fix-swiftlint-warnings-in-xcode-ios-TunnelMonitor-296 branch September 13, 2023 07:52
@buggmagnet
Copy link
Contributor

Nice job ! Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iOS Issues related to iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants