Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a few TODO comments #5137

Merged
merged 5 commits into from
Sep 11, 2023
Merged

Fix a few TODO comments #5137

merged 5 commits into from
Sep 11, 2023

Conversation

dlon
Copy link
Member

@dlon dlon commented Sep 8, 2023

This PR removes or fixes a few minor TODO comments.

Fixes DES-347.


This change is Reviewable

@linear
Copy link

linear bot commented Sep 8, 2023

DES-347 Fix TODO comments

Go through TODO comments in the code and remove or fix anything that is irrelevant or easily fixed.

@dlon dlon marked this pull request as ready for review September 8, 2023 15:01
Copy link
Contributor

@MarkusPettersson98 MarkusPettersson98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@dlon dlon merged commit ba70363 into main Sep 11, 2023
28 checks passed
@dlon dlon deleted the cleanup-todos branch September 11, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants