Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make TunnelManager dispatch to the main queue after deleting an account #5143

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

buggmagnet
Copy link
Contributor

@buggmagnet buggmagnet commented Sep 11, 2023

This change is Reviewable

@linear
Copy link

linear bot commented Sep 11, 2023

IOS-305 Crash after deleting an account

There's still a crash in the app when deleting an account. Just now in a different place.

xcode://organizer/crashes/downloadPoint?adamId=1488466513&platformId=iOS&installPlatformId=iOS&analyticsPointId=Dd-ygnFcfsvUANOm8EOQpA&bundleId=net.mullvad.MullvadVPN

Make sure to select the "App Store or Test Flight" filter to get the correct stack trace in Xcode Organizer

Screenshot 2023-09-11 at 09.48.26.png

Copy link
Contributor

@rablador rablador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@buggmagnet buggmagnet merged commit 4fd693b into main Sep 11, 2023
4 checks passed
@buggmagnet buggmagnet deleted the crash-after-deleting-an-account-ios-305 branch September 11, 2023 09:45
@pinkisemils pinkisemils added the iOS Issues related to iOS label Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iOS Issues related to iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants