Disable Module verifier, rename Settings to MullvadSettings #5168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IOS-320 Fix compilation issues on Xcode 15
Module verifier throws a mysterious error when trying to compile TunnelObfuscation and MullvadTransport on Xcode 15. |
pronebird
approved these changes
Sep 20, 2023
…clash with Apple private Framework of the same name
buggmagnet
force-pushed
the
fix-compilation-issues-on-xcode-15-ios-320
branch
from
77cfb7a to
da4e628
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the Module verifier option.
The module verifier makes Xcode create a dummy project that verifies if a Framework is properly built.
At the moment, our Framework that consume Rust dependencies do not seem to satisfy the module verifier, yet they work as expected when running on a device.
We also discovered that the name
Settingshappens to clash with an Apple internal framework also namedSettingswhen running on an iOS simulator linked with the iOS 17 runtime.
Thus this PR also renames
SettingstoMullvadSettingsThis change is