-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace ConstraintLayout with Row #5171
Replace ConstraintLayout with Row #5171
Conversation
DROID-340 Replace TopBar's ConstraintLayout with Row
When doing LoginScreen it was discovered that Top Bar will steal focus when in an input field and using the right arrow on the keyboard. Removing the use of ConstraintLayout solves this issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Rawa)
android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/component/TopBar.kt
line 55 at r1 (raw file):
verticalAlignment = Alignment.CenterVertically ) { if (isIconAndLogoVisible) {
If isIconAndLogoVisible
is false, as in the loading screen, the settings button will be moved to the upper left corner.
This is a regression from previous version.
ba58a5e
to
0c2acd7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @Pururun)
android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/component/TopBar.kt
line 55 at r1 (raw file):
Previously, Pururun (Jonatan Rhodin) wrote…
If
isIconAndLogoVisible
is false, as in the loading screen, the settings button will be moved to the upper left corner.
This is a regression from previous version.
a4624c6
to
c640289
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/component/TopBar.kt
line 55 at r1 (raw file):
Nice.
72078fe
to
3fa1244
Compare
In some cases (TextField) the constriantlayout would steal focus when user uses right arrow. This commit removes the use of ConstraintLayout so it won't interfere with input.
3fa1244
to
67d3484
Compare
In some cases (TextField) the constriantlayout would steal focus when user uses right arrow. This commit removes the use of ConstraintLayout so it won't interfere with input.
This is a requirement before we merge #5164
This change is