Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ConstraintLayout with Row #5171

Merged
merged 2 commits into from
Sep 25, 2023

Conversation

Rawa
Copy link
Contributor

@Rawa Rawa commented Sep 20, 2023

In some cases (TextField) the constriantlayout would steal focus when user uses right arrow. This commit removes the use of ConstraintLayout so it won't interfere with input.

This is a requirement before we merge #5164


This change is Reviewable

@linear
Copy link

linear bot commented Sep 20, 2023

DROID-340 Replace TopBar's ConstraintLayout with Row

When doing LoginScreen it was discovered that Top Bar will steal focus when in an input field and using the right arrow on the keyboard. Removing the use of ConstraintLayout solves this issue.

@Rawa Rawa requested a review from Pururun September 20, 2023 15:39
@Rawa Rawa self-assigned this Sep 20, 2023
@Rawa Rawa added the Android Issues related to Android label Sep 20, 2023
Copy link
Contributor

@Pururun Pururun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Rawa)


android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/component/TopBar.kt line 55 at r1 (raw file):

        verticalAlignment = Alignment.CenterVertically
    ) {
        if (isIconAndLogoVisible) {

If isIconAndLogoVisible is false, as in the loading screen, the settings button will be moved to the upper left corner.
This is a regression from previous version.

@Rawa Rawa force-pushed the replace-topbars-constraintlayout-with-row-droid-340 branch from ba58a5e to 0c2acd7 Compare September 22, 2023 09:30
Copy link
Contributor Author

@Rawa Rawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @Pururun)


android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/component/TopBar.kt line 55 at r1 (raw file):

Previously, Pururun (Jonatan Rhodin) wrote…

If isIconAndLogoVisible is false, as in the loading screen, the settings button will be moved to the upper left corner.
This is a regression from previous version.

Ah! Nice catch! Fixed!
Screenshot 2023-09-22 at 11.32.33.png

@Rawa Rawa force-pushed the replace-topbars-constraintlayout-with-row-droid-340 branch from a4624c6 to c640289 Compare September 22, 2023 09:33
Copy link
Contributor

@Pururun Pururun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved


android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/component/TopBar.kt line 55 at r1 (raw file):

Previously, Rawa (David Göransson) wrote…

Ah! Nice catch! Fixed!
Screenshot 2023-09-22 at 11.32.33.png

Nice.

@Pururun Pururun force-pushed the replace-topbars-constraintlayout-with-row-droid-340 branch 2 times, most recently from 72078fe to 3fa1244 Compare September 25, 2023 09:56
In some cases (TextField) the constriantlayout would steal focus when user uses right arrow. This commit removes the use of ConstraintLayout so it won't interfere with input.
@Pururun Pururun force-pushed the replace-topbars-constraintlayout-with-row-droid-340 branch from 3fa1244 to 67d3484 Compare September 25, 2023 10:21
@Pururun Pururun merged commit f0bb6f1 into main Sep 25, 2023
12 checks passed
@Pururun Pururun deleted the replace-topbars-constraintlayout-with-row-droid-340 branch September 25, 2023 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Issues related to Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants