Improve changelog dialog

[Pururun]

• Replace hardcoded font sizes and colors
• Place it within AppTheme so that corner radius are the same as other dialogs.
• Make it scrollable
• Change some text styles to be more in line with design

---

This change is 

[linear]

DROID-331 Fix ChangeLogDialog's corner radius

Screenshot_20230913-135620.png

[albin-mullvad]

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Pururun)

---

android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/dialog/ChangelogDialog.kt line 73 at r1 (raw file):

private fun ChangeListItem(text: String) {

    ConstraintLayout {

Did you consider switching from ConstraintLayout when cleaning up the code? @Rawa has shared some good reasons for why it might be good to avoid ConstraintLayout and instead work with more Compose-native Composables. Not saying saying it's a must for this PR though!

Code quote:

ConstraintLayout

[Pururun]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Rawa)

---

android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/dialog/ChangelogDialog.kt line 73 at r1 (raw file):

Previously, albin-mullvad wrote…

Did you consider switching from ConstraintLayout when cleaning up the code? @Rawa has shared some good reasons for why it might be good to avoid ConstraintLayout and instead work with more Compose-native Composables. Not saying saying it's a must for this PR though!

No I did not, but I think it would be good idea :)

[Rawa]

Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @albin-mullvad and @Pururun)

---

android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/dialog/ChangelogDialog.kt line 73 at r1 (raw file):

Previously, Pururun (Jonatan Rhodin) wrote…

No I did not, but I think it would be good idea :)

Yeah, usually ConstraintLayout is overkill in compose, there are places were it makes sense but most things are possible to accomplish without them.

[sabercodic]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @albin-mullvad and @Pururun)

[albin-mullvad]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved

---

android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/dialog/ChangelogDialog.kt line 73 at r1 (raw file):

Previously, Rawa (David Göransson) wrote…

Yeah, usually ConstraintLayout is overkill in compose, there are places were it makes sense but most things are possible to accomplish without them.

Nice improvement! Just make sure it looks the same as before.

[Pururun]

Reviewable status: complete! all files reviewed, all discussions resolved

---

android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/dialog/ChangelogDialog.kt line 73 at r1 (raw file):

Previously, albin-mullvad wrote…

Nice improvement! Just make sure it looks the same as before.

It actually looks better (more in line with design...)

[albin-mullvad]

Reviewable status: complete! all files reviewed, all discussions resolved

---

android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/dialog/ChangelogDialog.kt line 73 at r1 (raw file):

Previously, Pururun (Jonatan Rhodin) wrote…

It actually looks better (more in line with design...)

I don't doubt that! 😄 To clarify, I mean specifically that the bullet list gets correctly formatted, for example when an items break multiple lines such as this:

* This is a long changelist item
  covering mutiple lines according
  to the design spec.

* This is a long changelist item
covering mutiple lines which is
not according to the design spec.

[Pururun]

Reviewable status: complete! all files reviewed, all discussions resolved

---

android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/dialog/ChangelogDialog.kt line 73 at r1 (raw file):

Previously, albin-mullvad wrote…

I don't doubt that! 😄 To clarify, I mean specifically that the bullet list gets correctly formatted, for example when an items break multiple lines such as this:

* This is a long changelist item
  covering mutiple lines according
  to the design spec.

* This is a long changelist item
covering mutiple lines which is
not according to the design spec.

Ah I understand. Yes I checked that it was formatted according to design. :)

[mullmat]

Corner radius on the change log dialog looks wrong, what radius is defined? 😃

[Pururun]

Corner radius on the change log dialog looks wrong, what radius is defined? 😃

Fixed in: #5186