Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align copy with design for content blockers #5182

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

buggmagnet
Copy link
Contributor

@buggmagnet buggmagnet commented Sep 22, 2023

As the title says, we remove the "block" word from the content blockers to align with other platforms.


This change is Reviewable

@buggmagnet buggmagnet added the iOS Issues related to iOS label Sep 22, 2023
@buggmagnet buggmagnet requested a review from rablador September 22, 2023 08:10
@buggmagnet buggmagnet self-assigned this Sep 22, 2023
@linear
Copy link

linear bot commented Sep 22, 2023

IOS-319 DNS content blockers not following design

The DNS content blockers are not following the design, they are in a different order than on desktop and Android, and also have the word "block" in every blocker.
Please follow the design, thank you! :D

@buggmagnet buggmagnet force-pushed the dns-content-blockers-not-following-design-ios-319 branch from 0d61a60 to 0299f3a Compare September 22, 2023 09:08
Copy link
Contributor

@rablador rablador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@buggmagnet buggmagnet merged commit 990b5f8 into main Sep 22, 2023
@buggmagnet buggmagnet deleted the dns-content-blockers-not-following-design-ios-319 branch September 22, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iOS Issues related to iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants