Support running under build variant app ids #5184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albin-mullvad
force-pushed
the
support-running-under-build-variant-app-ids-droid-343
branch
from
34ff8d8 to
e949548
Compare
Rawa
approved these changes
Sep 22, 2023
There was a problem hiding this comment.
Reviewed 10 of 10 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
Rawa
approved these changes
Sep 22, 2023
There was a problem hiding this comment.
Reviewable status:
Pururun
approved these changes
Sep 22, 2023
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status:
albin-mullvad
force-pushed
the
support-running-under-build-variant-app-ids-droid-343
branch
from
e949548 to
84f6868
Compare
albin-mullvad
deleted the
support-running-under-build-variant-app-ids-droid-343
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to make sure the android app can run under build variant specific app ids, such as
net.mullvad.mullvadvpn.devmole.This change is