Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect text styles in info dialog #5202

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

Pururun
Copy link
Contributor

@Pururun Pururun commented Sep 27, 2023

Also make the dialog implement theme for colors and text styles


This change is Reviewable

@Pururun Pururun added the Android Issues related to Android label Sep 27, 2023
@Pururun Pururun requested review from Rawa and sabercodic September 27, 2023 15:53
@linear
Copy link

linear bot commented Sep 27, 2023

DROID-371 Incorrect text style in dialogs

This issue is about a regression where part of the text in the dialogs are styled incorrectly.

mullvad.png

Also we should fix the button to have the right properties, e.g text of "Got it!" should be bold

Copy link
Collaborator

@albin-mullvad albin-mullvad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Contributor

@sabercodic sabercodic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Also make the dialog implement theme for colors and text styles
@Pururun Pururun force-pushed the incorrect-text-style-in-dialogs-droid-371 branch from 2e44ef4 to 300bf42 Compare September 28, 2023 07:04
@Pururun Pururun merged commit fd49319 into main Sep 28, 2023
@Pururun Pururun deleted the incorrect-text-style-in-dialogs-droid-371 branch September 28, 2023 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Issues related to Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants