Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Too much spacing between text and button in local network dialog #5227

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Too much spacing between text and button in local network dialog #5227

merged 1 commit into from
Oct 6, 2023

Conversation

Rawa
Copy link
Contributor

@Rawa Rawa commented Oct 4, 2023 •
edited by faern
Loading

This change is Reviewable

@Rawa Rawa added the Android Issues related to Android label Oct 4, 2023
@Rawa Rawa self-assigned this Oct 4, 2023
@linear
Copy link

linear bot commented Oct 4, 2023

DROID-391 Too much spacing between text and button in local network sharing dialog

See the difference between the attached screenshots:

local-networking-dialog.png

obfuscation-dialog.png

@Rawa Rawa force-pushed the too-much-spacing-between-text-and-button-in-local-network-droid-391 branch from 82e2803 to f30aa46 Compare October 4, 2023 11:43
Pururun
Pururun approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@Pururun Pururun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Rawa Rawa force-pushed the too-much-spacing-between-text-and-button-in-local-network-droid-391 branch from f30aa46 to 6380eaa Compare October 6, 2023 08:34
@Pururun Pururun force-pushed the too-much-spacing-between-text-and-button-in-local-network-droid-391 branch from 6380eaa to 8c58508 Compare October 6, 2023 10:24
@Pururun Pururun merged commit cb8e525 into main Oct 6, 2023
@Pururun Pururun deleted the too-much-spacing-between-text-and-button-in-local-network-droid-391 branch October 6, 2023 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pururun Pururun Pururun approved these changes

Assignees

@Rawa Rawa

Labels
Android Issues related to Android
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rawa @Pururun