Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix duration logging #5229

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Fix duration logging #5229

merged 1 commit into from
Oct 5, 2023

Conversation

pronebird
Copy link
Contributor

@pronebird pronebird commented Oct 4, 2023 •
edited by faern
Loading

This PR fixes a regression introduced after switch to Duration. Just noticed today that logs state:

Start polling tunnel status every Duration(components: (seconds: 3, attoseconds: 0)) second(s).

Since Duration supports logFormat() we should use that function to output durations in log file.

This change is Reviewable

@pronebird pronebird requested a review from rablador October 4, 2023 12:36
@pronebird pronebird added the iOS Issues related to iOS label Oct 4, 2023
rablador
rablador approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@rablador rablador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@pronebird pronebird merged commit e711b1f into main Oct 5, 2023
4 checks passed
@pronebird pronebird deleted the fix-log-duration branch October 5, 2023 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rablador rablador rablador approved these changes

Assignees
No one assigned
Labels
iOS Issues related to iOS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pronebird @rablador