-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add UI for blocked state #5239
Add UI for blocked state #5239
Conversation
IOS-322 Add UI for blocked state
With the upcoming changes to the packet tunnel, we should update the UI to support this new connection state. Consider whether all error types require a shortcut for sending a problem report, and have a discussion in Slack. Do try and see how this works on Desktop/Android if you lack inspiration. Until IOS-223 is merged, work off of Andrei's branch instead of https://app.zeplin.io/project/5f928a32fdc9962af9018d70/screen/63c021ed2a0f36bd629f91f1 Link to all current in-app banner messages in the app on all platforms: |
1421c73
to
1b53b99
Compare
e5f95b5
to
f29c4f8
Compare
1b53b99
to
79dd686
Compare
2d49198
to
2595778
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion
ios/MullvadVPN/Notifications/Notification Providers/TunnelStatusNotificationProvider.swift
line 229 at r1 (raw file):
switch error { case .outdatedSchema: errorString = "Unable to start tunnel connection after update. Please send a problem report."
Although texts have been discussed with Matilda, slightly unsure about this one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 4 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: 3 of 4 files reviewed, 2 unresolved discussions (waiting on @rablador)
ios/MullvadVPN/Notifications/Notification Providers/TunnelStatusNotificationProvider.swift
line 229 at r1 (raw file):
Previously, rablador (Jon Petersson) wrote…
Although texts have been discussed with Matilda, slightly unsure about this one.
Eh looks good enough IMHO. It's a pretty rare situation, so it's good to encourage problem reports in this case.
ios/MullvadVPN/TunnelManager/TunnelManager.swift
line 1103 at r2 (raw file):
handleBlockedState(reason: .deviceRevoked) } else if restError.compareErrorCode(.invalidAccount) { handleBlockedState(reason: .invalidAccount)
I wonder how to test that .invalidAccount
case... 🤔
2595778
to
845d258
Compare
This change is